Merge pull request #74 from codecrafters-io/fix-starter

Refactor server code and remove unnecessary server.close() calls

Author: rohitpaulk

compiled_starters/javascript/app/main.js

@@ -7,7 +7,6 @@ console.log("Logs from your program will appear here!");
 // const server = net.createServer((socket) => {
 //   socket.on("close", () => {
 //     socket.end();
-//     server.close();
 //   });
 // });
 //

compiled_starters/typescript/app/main.ts

@@ -1,13 +1,13 @@
-import * as net from 'net';
-
-const server = net.createServer((socket) => {
-    socket.end();
-});
+import * as net from "net";
 
 // You can use print statements as follows for debugging, they'll be visible when running tests.
 console.log("Logs from your program will appear here!");
 
 // Uncomment this to pass the first stage
-// server.listen(4221, 'localhost', () => {
-//     console.log('Server is running on port 4221');
+// const server = net.createServer((socket) => {
+//   socket.on("close", () => {
+//     socket.end();
+//   });
 // });
+//
+// server.listen(4221, "localhost");

dockerfiles/zig-0.12.Dockerfile

@@ -1,4 +1,4 @@
-FROM alpine:3.19
+FROM alpine:3.20
 
 # Add the testing repository
 RUN echo "@community http://dl-cdn.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories

solutions/javascript/01-at4/code/app/main.js

@@ -3,7 +3,6 @@ const net = require("net");
 const server = net.createServer((socket) => {
   socket.on("close", () => {
     socket.end();
-    server.close();
   });
 });
 

solutions/javascript/01-at4/diff/app/main.js.diff

@@ -1,20 +1,18 @@
-@@ -1,14 +1,10 @@
+@@ -1,13 +1,9 @@
  const net = require("net");
 
 -// You can use print statements as follows for debugging, they'll be visible when running tests.
 -console.log("Logs from your program will appear here!");
 +const server = net.createServer((socket) => {
 +  socket.on("close", () => {
 +    socket.end();
-+    server.close();
 +  });
 +});
 
 -// Uncomment this to pass the first stage
 -// const server = net.createServer((socket) => {
 -//   socket.on("close", () => {
 -//     socket.end();
--//     server.close();
 -//   });
 -// });
 -//

solutions/javascript/01-at4/explanation.md

@@ -7,7 +7,6 @@ Study and uncomment the relevant code:
 const server = net.createServer((socket) => {
   socket.on("close", () => {
     socket.end();
-    server.close();
   });
 });
 

solutions/typescript/01-at4/code/app/main.ts

@@ -1,9 +1,9 @@
-import * as net from 'net';
+import * as net from "net";
 
 const server = net.createServer((socket) => {
+  socket.on("close", () => {
     socket.end();
+  });
 });
 
-server.listen(4221, 'localhost', () => {
-    console.log('Server is running on port 4221');
-});
+server.listen(4221, "localhost");

solutions/typescript/01-at4/diff/app/main.ts.diff

@@ -1,17 +1,20 @@
 @@ -1,13 +1,9 @@
- import * as net from 'net';
-
- const server = net.createServer((socket) => {
-     socket.end();
- });
+ import * as net from "net";
 
 -// You can use print statements as follows for debugging, they'll be visible when running tests.
 -console.log("Logs from your program will appear here!");
--
++const server = net.createServer((socket) => {
++  socket.on("close", () => {
++    socket.end();
++  });
++});
+
 -// Uncomment this to pass the first stage
--// server.listen(4221, 'localhost', () => {
--//     console.log('Server is running on port 4221');
+-// const server = net.createServer((socket) => {
+-//   socket.on("close", () => {
+-//     socket.end();
+-//   });
 -// });
-+server.listen(4221, 'localhost', () => {
-+    console.log('Server is running on port 4221');
-+});
+-//
+-// server.listen(4221, "localhost");
++server.listen(4221, "localhost");

solutions/typescript/01-at4/explanation.md

@@ -4,9 +4,13 @@ Study and uncomment the relevant code:
 
 ```typescript
 // Uncomment this to pass the first stage
-server.listen(4221, 'localhost', () => {
-    console.log('Server is running on port 4221');
+const server = net.createServer((socket) => {
+  socket.on("close", () => {
+    socket.end();
+  });
 });
+
+server.listen(4221, "localhost");
 ```
 
 Push your changes to pass the first stage:

starter_templates/javascript/app/main.js

@@ -7,7 +7,6 @@ console.log("Logs from your program will appear here!");
 // const server = net.createServer((socket) => {
 //   socket.on("close", () => {
 //     socket.end();
-//     server.close();
 //   });
 // });
 //