Merge pull request #34 from codecov/release-0.0.29

chore(release): 0.0.29 and some small fixes

Author: thomasrockhu-codecov

.github/workflows/ci.yml

@@ -23,3 +23,12 @@ jobs:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
           CODECOV_FAIL_ON_ERROR: true
           CODECOV_FLAGS: flag1,flag2
+  shellcheck:
+    runs-on: macos-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Install shellcheck
+        run: brew install shellcheck
+      - name: Run shellcheck
+        run: shellcheck dist/codecov.sh --severity=error

dist/codecov.sh

@@ -1,12 +1,12 @@
 #!/usr/bin/env bash
-CC_WRAPPER_VERSION="0.0.28"
+CC_WRAPPER_VERSION="0.0.29"
 set +u
 say() {
   echo -e "$1"
 }
 exit_if_error() {
   say "$r==> $1$x"
-  if [ $CC_FAIL_ON_ERROR = true ];
+  if [ "$CC_FAIL_ON_ERROR" = true ];
   then
      say "$r    Exiting...$x"
      exit 1;
@@ -84,10 +84,10 @@ else
   cc_url="$cc_url/${CC_VERSION}"
   cc_url="$cc_url/${cc_os}/${cc_filename}"
   say "$g ->$x Downloading $b${cc_url}$x"
-  curl -Os $cc_url
+  curl -Os "$cc_url"
   say "$g==>$x Finishing downloading $b${cc_os}:${CC_VERSION}$x"
   version_url="https://cli.codecov.io/${cc_os}/${CC_VERSION}"
-  version=$(curl -s $version_url -H "Accept:application/json" | jq -r '.version')
+  version=$(curl -s "$version_url" -H "Accept:application/json" | jq -r '.version')
   say "      Version: $b$version$x"
   say " "
 fi
@@ -123,7 +123,7 @@ fi
 cc_cli_args=()
 cc_cli_args+=( $(k_arg AUTO_LOAD_PARAMS_FROM) $(v_arg AUTO_LOAD_PARAMS_FROM))
 cc_cli_args+=( $(k_arg ENTERPRISE_URL) $(v_arg ENTERPRISE_URL))
-if [ -n $CC_YML_PATH ]
+if [ -n "$CC_YML_PATH" ]
 then
   cc_cli_args+=( "--codecov-yml-path" )
   cc_cli_args+=( "$CC_YML_PATH" )

scripts/download.sh

@@ -39,11 +39,11 @@ else
   codecov_url="$codecov_url/${CODECOV_VERSION}"
   codecov_url="$codecov_url/${codecov_os}/${codecov_filename}"
   say "$g ->$x Downloading $b${codecov_url}$x"
-  curl -Os $codecov_url
+  curl -Os "$codecov_url"
   say "$g==>$x Finishing downloading $b${codecov_os}:${CODECOV_VERSION}$x"
 
   version_url="https://cli.codecov.io/${codecov_os}/${CODECOV_VERSION}"
-  version=$(curl -s $version_url -H "Accept:application/json" | jq -r '.version')
+  version=$(curl -s "$version_url" -H "Accept:application/json" | jq -r '.version')
   say "      Version: $b$version$x"
   say " "
 fi

scripts/set_cli_args.sh

@@ -4,7 +4,7 @@ codecov_cli_args=()
 
 codecov_cli_args+=( $(k_arg AUTO_LOAD_PARAMS_FROM) $(v_arg AUTO_LOAD_PARAMS_FROM))
 codecov_cli_args+=( $(k_arg ENTERPRISE_URL) $(v_arg ENTERPRISE_URL))
-if [ -n $CODECOV_YML_PATH ]
+if [ -n "$CODECOV_YML_PATH" ]
 then
   codecov_cli_args+=( "--codecov-yml-path" )
   codecov_cli_args+=( "$CODECOV_YML_PATH" )

scripts/set_defaults.sh

@@ -7,7 +7,7 @@ say() {
 
 exit_if_error() {
   say "$r==> $1$x"
-  if [ $CODECOV_FAIL_ON_ERROR = true ];
+  if [ "$CODECOV_FAIL_ON_ERROR" = true ];
   then
      say "$r    Exiting...$x"
      exit 1;

scripts/set_upload_coverage_args.sh

@@ -1,2 +1,2 @@
 #!/usr/bin/env bash
-CODECOV_WRAPPER_VERSION="0.0.28"
+CODECOV_WRAPPER_VERSION="0.0.29"