Merge pull request #3 from codeccoop/fix/http-setting-register

Fix http setting register adn skip heartbeat migrations

Author: Orzo Cogorzo

forms-bridge/deps/http

@@ -587,6 +587,11 @@ private static function notify_error(
 	 * Apply db migrations on plugin upgrades.
 	 */
 	private static function do_migrations() {
+		$action = sanitize_text_field( wp_unslash( $_POST['action'] ?? '' ) );
+		if ( 'heartbeat' === $action && wp_doing_ajax() ) {
+			return;
+		}
+
 		$from = get_option( self::DB_VERSION, self::version() );
 
 		if ( ! preg_match( '/^\d+\.\d+\.\d+$/', $from ) ) {

forms-bridge/includes/class-forms-bridge.php

@@ -1,9 +1,19 @@
 <?php
+/**
+ * Database migration to version 3.0.0
+ *
+ * @package formsbridge
+ */
+
+// phpcs:disable WordPress.Files.FileName
 
 if ( ! defined( 'ABSPATH' ) ) {
 	exit();
 }
 
+/**
+ * Migration 3.0.0
+ */
 function forms_bridge_migration_300() {
 	$setting_names = array( 'rest-api', 'odoo', 'financoop', 'google-sheets' );
 

forms-bridge/migrations/3.0.0.php

@@ -1,9 +1,19 @@
 <?php
+/**
+ * Database migration to version 3.0.4
+ *
+ * @package formsbridge
+ */
+
+// phpcs:disable WordPress.Files.FileName
 
 if ( ! defined( 'ABSPATH' ) ) {
 	exit();
 }
 
+/**
+ * Migration 3.0.4
+ */
 function forms_bridge_migration_304() {
 	$setting_names = array( 'rest-api', 'odoo', 'financoop', 'google-sheets' );
 

forms-bridge/migrations/3.0.4.php

@@ -1,9 +1,19 @@
 <?php
+/**
+ * Database migration to version 3.1.0
+ *
+ * @package formsbridge
+ */
+
+// phpcs:disable WordPress.Files.FileName
 
 if ( ! defined( 'ABSPATH' ) ) {
 	exit();
 }
 
+/**
+ * Migration 3.1.0
+ */
 function forms_bridge_migration_310() {
 	$setting_names = array(
 		'rest-api',

forms-bridge/migrations/3.1.0.php

@@ -1,11 +1,21 @@
 <?php
+/**
+ * Database migration to version 4.0.0
+ *
+ * @package formsbridge
+ */
+
+// phpcs:disable WordPress.Files.FileName
 
 use FORMS_BRIDGE\Addon;
 
 if ( ! defined( 'ABSPATH' ) ) {
 	exit();
 }
 
+/**
+ * Migration 4.0.0
+ */
 function forms_bridge_migration_400() {
 	$setting_names = array(
 		'bigin',
@@ -245,7 +255,7 @@ function forms_bridge_migration_400() {
 	}
 
 	$registry = get_option( 'forms_bridge_addons' );
-	if ( $registry && is_array( $registry ) ) {
+	if ( isset( $registry['rest-api'] ) ) {
 		$registry['rest'] = $registry['rest-api'];
 		unset( $registry['rest-api'] );
 		update_option( 'forms_bridge_addons', $registry );

forms-bridge/migrations/4.0.0.php

@@ -1,14 +1,30 @@
 <?php
+/**
+ * Database migration to version 4.0.7
+ *
+ * @package formsbridge
+ */
+
+// phpcs:disable WordPress.Files.FileName
 
 if ( ! defined( 'ABSPATH' ) ) {
 	exit();
 }
 
+/**
+ * Migration 4.0.7
+ */
 function forms_bridge_migration_407() {
 	$http = get_option( 'http-bridge_general', array() ) ?: array(
 		'backends'    => array(),
 		'credentials' => array(),
 	);
 
-	update_option( 'forms-bridge_http', $http );
+	$result = update_option( 'forms-bridge_http', $http );
+
+	if ( $result ) {
+		delete_option( 'http-bridge_general' );
+	}
 }
+
+forms_bridge_migration_407();