feat(annotations): Change default metadata values to use name attribute instead of "Not specified"

Author: codeboyzhou

src/main/java/com/github/codeboyzhou/mcp/declarative/annotation/McpJsonSchemaProperty.java

@@ -21,23 +21,22 @@
 @Retention(RetentionPolicy.RUNTIME)
 public @interface McpJsonSchemaProperty {
   /**
-   * The name of the JSON schema property. If not specified, the field name will be used.
+   * The name of the JSON schema property. Defaults to the Java field name.
    *
    * @return the name of the JSON schema property
    */
   String name() default StringHelper.EMPTY;
 
   /**
-   * The description of the JSON schema property. If not specified, the default value {@code "Not
-   * specified"} will be used.
+   * The description of the JSON schema property. Defaults to the value of the {@code name}
+   * attribute.
    *
    * @return the description of the JSON schema property
    */
   String description() default StringHelper.EMPTY;
 
   /**
-   * Whether the JSON schema property is required. If not specified, the default value {@code false}
-   * will be used.
+   * Whether the JSON schema property is required. Defaults to {@code false}.
    *
    * @return whether the JSON schema property is required
    */

src/main/java/com/github/codeboyzhou/mcp/declarative/annotation/McpPrompt.java

@@ -11,7 +11,7 @@
  *
  * <p>The prompt's name defaults to the name of the annotated method. Prompt metadata such as title
  * and description can be specified via the corresponding attributes. If omitted, these metadata
- * fields will default to the literal string "Not specified".
+ * fields will default to the value of the {@code name} attribute.
  *
  * <p>Example usage:
  *
@@ -38,14 +38,14 @@
   String name() default StringHelper.EMPTY;
 
   /**
-   * The title of the prompt. Defaults to the literal string "Not specified".
+   * The title of the prompt. Defaults to the value of the {@code name} attribute.
    *
    * @return the title of the prompt
    */
   String title() default StringHelper.EMPTY;
 
   /**
-   * The description of the prompt. Defaults to the literal string "Not specified".
+   * The description of the prompt. Defaults to the value of the {@code name} attribute.
    *
    * @return the description of the prompt
    */

src/main/java/com/github/codeboyzhou/mcp/declarative/annotation/McpPromptParam.java

@@ -12,7 +12,7 @@
  *
  * <p>The parameter's name must be specified explicitly. Parameter metadata such as title,
  * description, and required can be specified via the corresponding attributes. If omitted, these
- * metadata fields will default to the literal string "Not specified" and {@code false}.
+ * metadata fields will default to the value of the {@code name} attribute and {@code false}.
  *
  * <p>Example usage:
  *
@@ -39,14 +39,14 @@
   String name();
 
   /**
-   * The title of the prompt parameter. Defaults to the literal string "Not specified".
+   * The title of the prompt parameter. Defaults to the value of the {@code name} attribute.
    *
    * @return the title of the prompt parameter
    */
   String title() default StringHelper.EMPTY;
 
   /**
-   * The description of the prompt parameter. Defaults to the literal string "Not specified".
+   * The description of the prompt parameter. Defaults to the value of the {@code name} attribute.
    *
    * @return the description of the prompt parameter
    */

src/main/java/com/github/codeboyzhou/mcp/declarative/annotation/McpResource.java

@@ -12,7 +12,7 @@
  *
  * <p>The resource's URI must be specified explicitly. Resource metadata such as name, title,
  * description, and MIME type can be specified via the corresponding attributes. If omitted, these
- * metadata fields will default to the literal string "Not specified" and "text/plain".
+ * metadata fields will default to the value of the {@code name} attribute and "text/plain".
  *
  * <p>Example usage:
  *
@@ -46,14 +46,14 @@
   String name() default StringHelper.EMPTY;
 
   /**
-   * The title of the resource. Defaults to the literal string "Not specified".
+   * The title of the resource. Defaults to the value of the {@code name} attribute.
    *
    * @return the title of the resource
    */
   String title() default StringHelper.EMPTY;
 
   /**
-   * The description of the resource. Defaults to the literal string "Not specified".
+   * The description of the resource. Defaults to the value of the {@code name} attribute.
    *
    * @return the description of the resource
    */

src/main/java/com/github/codeboyzhou/mcp/declarative/annotation/McpTool.java

@@ -11,7 +11,7 @@
  *
  * <p>The tool's name defaults to the name of the annotated method. Tool metadata such as title and
  * description can be specified via the corresponding attributes. If omitted, these metadata fields
- * will default to the literal string "Not specified".
+ * will default to the value of the {@code name} attribute.
  *
  * <p>Example usage:
  *
@@ -38,14 +38,14 @@
   String name() default StringHelper.EMPTY;
 
   /**
-   * The title of the tool. Defaults to the literal string "Not specified".
+   * The title of the tool. Defaults to the value of the {@code name} attribute.
    *
    * @return the title of the tool
    */
   String title() default StringHelper.EMPTY;
 
   /**
-   * The description of the tool. Defaults to the literal string "Not specified".
+   * The description of the tool. Defaults to the value of the {@code name} attribute.
    *
    * @return the description of the tool
    */

src/main/java/com/github/codeboyzhou/mcp/declarative/annotation/McpToolParam.java

@@ -12,7 +12,7 @@
  *
  * <p>The parameter's name must be specified explicitly. Parameter metadata such as description and
  * required status can be specified via the corresponding attributes. If omitted, these metadata
- * fields will default to the literal string "Not specified" and {@code false}.
+ * fields will default to the value of the {@code name} attribute and {@code false}.
  *
  * <p>Example usage:
  *
@@ -36,7 +36,7 @@
   String name();
 
   /**
-   * The description of the tool parameter. Defaults to the literal string "Not specified".
+   * The description of the tool parameter. Defaults to the value of the {@code name} attribute.
    *
    * @return the description of the tool parameter
    */

src/main/java/com/github/codeboyzhou/mcp/declarative/server/component/AbstractMcpServerComponent.java

@@ -14,9 +14,6 @@
  * @author codeboyzhou
  */
 public abstract class AbstractMcpServerComponent<T> implements McpServerComponent<T> {
-  /** The default value to use when a component attribute is not specified. */
-  protected static final String NOT_SPECIFIED = "Not specified";
-
   /** The dependency injector to use for injecting component attributes. */
   protected final DependencyInjector injector;
 
@@ -30,16 +27,19 @@ protected AbstractMcpServerComponent() {
   }
 
   /**
-   * Resolves the value of a component attribute, using the resource bundle for localization if i18n
-   * is enabled.
+   * Localizes the attribute with the specified i18n key using the resource bundle, or returns the
+   * default value if the key is not found in the bundle.
    *
-   * @param attributeLiteralValue the literal value of the component attribute
-   * @return the resolved value of the component attribute
+   * @param i18nKey the i18n key of the attribute to localize
+   * @param defaultValue the default value to return if the i18n key is not found in the bundle
+   * @return the localized value of the attribute, or the default value if the i18n key is not found
+   *     in the bundle
    */
-  protected String resolveComponentAttributeValue(String attributeLiteralValue) {
-    if (bundle != null && bundle.containsKey(attributeLiteralValue)) {
-      return bundle.getString(attributeLiteralValue);
+  protected String localizeAttribute(String i18nKey, String defaultValue) {
+    if (bundle != null && bundle.containsKey(i18nKey)) {
+      return bundle.getString(i18nKey);
     }
-    return StringHelper.defaultIfBlank(attributeLiteralValue, NOT_SPECIFIED);
+    // If we don't need to localize, just return the literal value or default value
+    return StringHelper.defaultIfBlank(i18nKey, defaultValue);
   }
 }

src/main/java/com/github/codeboyzhou/mcp/declarative/server/component/McpServerPrompt.java

@@ -45,8 +45,8 @@ public McpServerFeatures.SyncPromptSpecification create(Method method) {
     McpPrompt promptMethod = methodCache.getMcpPromptAnnotation();
     final String name =
         StringHelper.defaultIfBlank(promptMethod.name(), methodCache.getMethodName());
-    final String title = resolveComponentAttributeValue(promptMethod.title());
-    final String description = resolveComponentAttributeValue(promptMethod.description());
+    final String title = localizeAttribute(promptMethod.title(), name);
+    final String description = localizeAttribute(promptMethod.description(), name);
 
     List<McpSchema.PromptArgument> promptArgs = createPromptArguments(methodCache.getParameters());
     McpSchema.Prompt prompt = new McpSchema.Prompt(name, title, description, promptArgs);
@@ -94,8 +94,8 @@ private List<McpSchema.PromptArgument> createPromptArguments(Parameter[] methodP
       if (param.isAnnotationPresent(McpPromptParam.class)) {
         McpPromptParam promptParam = param.getAnnotation(McpPromptParam.class);
         final String name = promptParam.name();
-        final String title = resolveComponentAttributeValue(promptParam.title());
-        final String description = resolveComponentAttributeValue(promptParam.description());
+        final String title = localizeAttribute(promptParam.title(), name);
+        final String description = localizeAttribute(promptParam.description(), name);
         final boolean required = promptParam.required();
         promptArguments.add(new McpSchema.PromptArgument(name, title, description, required));
       }

src/main/java/com/github/codeboyzhou/mcp/declarative/server/component/McpServerResource.java

@@ -31,8 +31,8 @@ public McpServerFeatures.SyncResourceSpecification create(Method method) {
 
     McpResource res = methodCache.getMcpResourceAnnotation();
     final String name = StringHelper.defaultIfBlank(res.name(), methodCache.getMethodName());
-    final String title = resolveComponentAttributeValue(res.title());
-    final String description = resolveComponentAttributeValue(res.description());
+    final String title = localizeAttribute(res.title(), name);
+    final String description = localizeAttribute(res.description(), name);
 
     McpSchema.Resource resource =
         McpSchema.Resource.builder()

src/main/java/com/github/codeboyzhou/mcp/declarative/server/component/McpServerTool.java

@@ -53,8 +53,8 @@ public McpServerFeatures.SyncToolSpecification create(Method method) {
 
     McpTool toolMethod = methodCache.getMcpToolAnnotation();
     final String name = StringHelper.defaultIfBlank(toolMethod.name(), methodCache.getMethodName());
-    final String title = resolveComponentAttributeValue(toolMethod.title());
-    final String description = resolveComponentAttributeValue(toolMethod.description());
+    final String title = localizeAttribute(toolMethod.title(), name);
+    final String description = localizeAttribute(toolMethod.description(), name);
 
     McpSchema.JsonSchema inputSchema = createJsonSchema(methodCache.getParameters());
     Map<String, Object> outputSchema = createJsonSchemaDefinition(methodCache.getReturnType());
@@ -131,7 +131,7 @@ private McpSchema.JsonSchema createJsonSchema(Parameter[] methodParams) {
           definitions.put(definitionClassName, definition);
         } else {
           property.put("type", JavaTypeToJsonSchemaMapper.getJsonSchemaType(definitionClass));
-          property.put("description", resolveComponentAttributeValue(toolParam.description()));
+          property.put("description", localizeAttribute(toolParam.description(), parameterName));
         }
         properties.put(parameterName, property);
 
@@ -176,10 +176,10 @@ private Map<String, Object> createJsonSchemaDefinition(Class<?> definitionClass)
       }
 
       Map<String, Object> fieldProperties = new HashMap<>();
+      final String fieldName = StringHelper.defaultIfBlank(property.name(), field.getName());
       fieldProperties.put("type", JavaTypeToJsonSchemaMapper.getJsonSchemaType(field.getType()));
-      fieldProperties.put("description", resolveComponentAttributeValue(property.description()));
+      fieldProperties.put("description", localizeAttribute(property.description(), fieldName));
 
-      final String fieldName = StringHelper.defaultIfBlank(property.name(), field.getName());
       properties.put(fieldName, fieldProperties);
 
       if (property.required()) {