Fixed sketch test.

- Creating a public sketch initially.
- Waiting for loading screen to appear when opening editor's page.

Author: freskoulix

codebender_testing/utils.py

@@ -879,7 +879,7 @@ def create_sketch(self, privacy, name, description):
         """Creates a sketch with a given name"""
         createSketchBtn = self.get_element(By.ID, 'create_sketch_btn')
         createSketchBtn.click()
-        WebDriverWait(self.driver, VERIFY_TIMEOUT).until(
+        WebDriverWait(self.driver, TIMEOUT['LOCATE_ELEMENT']).until(
                 expected_conditions.visibility_of_element_located(
                     (By.CSS_SELECTOR, "#create-sketch-modal")
                 )
@@ -893,12 +893,18 @@ def create_sketch(self, privacy, name, description):
 
         createBtn = self.get_element(By.ID, 'create-sketch-modal-action-button')
         createBtn.click()
-        WebDriverWait(self.driver, VERIFY_TIMEOUT).until(
-                expected_conditions.invisibility_of_element_located(
-                    (By.CSS_SELECTOR, "#editor-loading-screen")
-                )
+
+        WebDriverWait(self.driver, TIMEOUT['LOCATE_ELEMENT']).until(
+            expected_conditions.visibility_of_element_located(
+                (By.CSS_SELECTOR, "#editor-loading-screen")
             )
-        WebDriverWait(self.driver, VERIFY_TIMEOUT).until(
+        )
+        WebDriverWait(self.driver, TIMEOUT['LOCATE_ELEMENT']).until(
+            expected_conditions.invisibility_of_element_located(
+                (By.CSS_SELECTOR, "#editor-loading-screen")
+            )
+        )
+        WebDriverWait(self.driver, TIMEOUT['LOCATE_ELEMENT']).until(
             expected_conditions.element_to_be_clickable(
                 (By.CSS_SELECTOR, "#editor_heading_project_name")
             )

tests/common/sketch/test_sketch.py

@@ -26,7 +26,7 @@ class TestSketch(SeleniumTestCase):
     def create_test_project(self, tester_login):
         """Makes sure we are logged in and have a project open before
         performing any of these tests."""
-        self.create_sketch('private' , TEST_PROJECT_NAME + '_initial', 'short description')
+        self.create_sketch('public' , TEST_PROJECT_NAME + '_initial', 'short description')
 
     def test_rename_project(self):
         self.change_name_editor(TEST_PROJECT_NAME)