Merge pull request #802 from code0-tech/renovate/good_job-4.x-lockfile

Update dependency good_job to v4.13.1

Author: Taucher2003

Gemfile.lock

@@ -95,15 +95,15 @@ GEM
       rails (>= 8.0.1)
       zeitwerk (~> 2.7)
     coderay (1.1.3)
-    concurrent-ruby (1.3.5)
-    connection_pool (2.5.4)
+    concurrent-ruby (1.3.6)
+    connection_pool (2.5.5)
     crass (1.0.6)
     csv (3.3.5)
     database_cleaner-active_record (2.2.2)
       activerecord (>= 5.a)
       database_cleaner-core (~> 2.0)
     database_cleaner-core (2.0.1)
-    date (3.4.1)
+    date (3.5.1)
     debug (1.11.1)
       irb (~> 1.10)
       reline (>= 0.3.8)
@@ -112,9 +112,9 @@ GEM
     diff-lcs (1.6.2)
     docile (1.4.1)
     drb (2.2.3)
-    erb (5.0.3)
+    erb (5.1.3)
     erubi (1.13.1)
-    et-orbi (1.3.0)
+    et-orbi (1.4.0)
       tzinfo
     factory_bot (6.5.5)
       activesupport (>= 6.1.0)
@@ -123,12 +123,12 @@ GEM
       railties (>= 6.1.0)
     ffi (1.17.1)
     fiber-storage (0.1.2)
-    fugit (1.11.2)
-      et-orbi (~> 1, >= 1.2.11)
+    fugit (1.12.1)
+      et-orbi (~> 1.4)
       raabro (~> 1.4)
     globalid (1.3.0)
       activesupport (>= 6.1)
-    good_job (4.12.1)
+    good_job (4.13.1)
       activejob (>= 6.1.0)
       activerecord (>= 6.1.0)
       concurrent-ruby (>= 1.3.1)
@@ -157,7 +157,7 @@ GEM
       mini_magick (>= 4.9.5, < 6)
       ruby-vips (>= 2.0.17, < 3)
     io-console (0.8.2)
-    irb (1.15.3)
+    irb (1.16.0)
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
@@ -173,7 +173,7 @@ GEM
       activesupport (>= 4)
       railties (>= 4)
       request_store (~> 1.0)
-    loofah (2.24.1)
+    loofah (2.25.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     mail (2.8.1)
@@ -186,7 +186,7 @@ GEM
     mini_magick (4.13.2)
     mini_mime (1.1.5)
     mini_portile2 (2.8.9)
-    minitest (5.26.2)
+    minitest (5.27.0)
     msgpack (1.8.0)
     multi_xml (0.7.2)
       bigdecimal (~> 3.1)
@@ -222,7 +222,7 @@ GEM
     pry-byebug (3.11.0)
       byebug (~> 12.0)
       pry (>= 0.13, < 0.16)
-    psych (5.2.6)
+    psych (5.3.1)
       date
       stringio
     public_suffix (6.0.2)
@@ -236,7 +236,7 @@ GEM
       rack (>= 3.0.0)
     rack-test (2.2.0)
       rack (>= 1.3)
-    rackup (2.2.1)
+    rackup (2.3.1)
       rack (>= 3)
     rails (8.0.3)
       actioncable (= 8.0.3)
@@ -270,9 +270,10 @@ GEM
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
     rake (13.3.1)
-    rdoc (6.14.2)
+    rdoc (6.17.0)
       erb
       psych (>= 4.0.0)
+      tsort
     regexp_parser (2.10.0)
     reline (0.6.3)
       io-console (~> 0.5)
@@ -371,10 +372,10 @@ GEM
       simplecov (~> 0.19)
     simplecov-html (0.13.2)
     simplecov_json_formatter (0.1.4)
-    stringio (3.1.9)
+    stringio (3.2.0)
     test-prof (1.4.4)
     thor (1.4.0)
-    timeout (0.4.4)
+    timeout (0.6.0)
     tsort (0.2.0)
     tucana (0.0.49)
       grpc (~> 1.64)
@@ -390,7 +391,7 @@ GEM
       base64
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
-    zeitwerk (2.7.3)
+    zeitwerk (2.7.4)
 
 PLATFORMS
   ruby

db/migrate/20251221212455_add_index_good_jobs_finished_at_for_cleanup.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class AddIndexGoodJobsFinishedAtForCleanup < Code0::ZeroTrack::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def change
+    reversible do |dir|
+      dir.up do
+        # Ensure this incremental update migration is idempotent
+        # with monolithic install migration.
+        return if connection.index_exists? :good_jobs, [:finished_at], name: :index_good_jobs_jobs_on_finished_at_only
+      end
+    end
+
+    add_index :good_jobs, [:finished_at], where: 'finished_at IS NOT NULL',
+                                          name: :index_good_jobs_jobs_on_finished_at_only, algorithm: :concurrently
+  end
+end

db/migrate/20251221212456_remove_extraneous_finished_at_index.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class RemoveExtraneousFinishedAtIndex < Code0::ZeroTrack::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def change
+    reversible do |dir|
+      dir.up do
+        # Ensure this incremental update migration is idempotent
+        # with monolithic install migration.
+        return unless connection.index_exists? :good_jobs, [:finished_at], name: :index_good_jobs_jobs_on_finished_at
+      end
+    end
+
+    remove_index :good_jobs, [:finished_at], where: 'retried_good_job_id IS NULL AND finished_at IS NOT NULL',
+                                             name: :index_good_jobs_jobs_on_finished_at, algorithm: :concurrently
+  end
+end

db/schema_migrations/20251221212455

@@ -0,0 +1 @@
+459a9b0b80b38af5e26a482eacfcc3bf63b56b47845ae02ba814b1d6ecb4bde6

db/schema_migrations/20251221212456

@@ -0,0 +1 @@
+6aabe9c35c16f35e4c34fd0b0d5ff4136ffc9e9d16520e1f1d96513a1b160ed7

db/structure.sql

@@ -1133,7 +1133,7 @@ CREATE INDEX index_good_job_jobs_for_candidate_lookup ON good_jobs USING btree (
 
 CREATE UNIQUE INDEX index_good_job_settings_on_key ON good_job_settings USING btree (key);
 
-CREATE INDEX index_good_jobs_jobs_on_finished_at ON good_jobs USING btree (finished_at) WHERE ((retried_good_job_id IS NULL) AND (finished_at IS NOT NULL));
+CREATE INDEX index_good_jobs_jobs_on_finished_at_only ON good_jobs USING btree (finished_at) WHERE (finished_at IS NOT NULL);
 
 CREATE INDEX index_good_jobs_jobs_on_priority_created_at_when_unfinished ON good_jobs USING btree (priority DESC NULLS LAST, created_at) WHERE (finished_at IS NULL);
 

spec/all_extension_classes_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+# rubocop:disable RSpec/DescribeClass -- this test is testing global application state
+RSpec.describe 'application state', :eager_load do
+  describe 'all extension classes' do
+    # rubocop:disable RSpec/NoExpectationExample -- these tests fail with exceptions
+    it 'overrides only defined methods' do
+      Sagittarius::Override.verify_all!
+    end
+
+    it 'marks all overridden methods as override' do
+      InjectExtensions.extended_constants.each_pair do |core, extensions|
+        Sagittarius::Override.verify_missing_overrides!(core, extensions)
+      end
+    end
+    # rubocop:enable RSpec/NoExpectationExample
+  end
+
+  describe 'good_job' do
+    it { expect(GoodJob.migrated?).to be true }
+  end
+end
+# rubocop:enable RSpec/DescribeClass