fix: attach cache metadata to JSON responses

Author: mowens3

src/Controller/PathResolverController.php

@@ -69,7 +69,7 @@ public function resolve(Request $request): CacheableJsonResponse {
       $cacheable->addCacheContexts(['languages:language_content']);
     }
 
-    $cacheable->applyTo($response);
+    $response->addCacheableDependency($cacheable);
 
     $this->applySecurityHeaders($response, $max_age);
 
@@ -94,7 +94,7 @@ private function errorResponse(int $status, string $title, string $detail): Cach
 
     $cacheable = new CacheableMetadata();
     $cacheable->setCacheMaxAge(0);
-    $cacheable->applyTo($response);
+    $response->addCacheableDependency($cacheable);
     $this->applySecurityHeaders($response, 0);
 
     return $response;

src/Controller/RoutesFeedController.php

@@ -119,7 +119,7 @@ public function routes(Request $request): CacheableJsonResponse {
     $cacheable = new CacheableMetadata();
     $cacheable->setCacheMaxAge(0);
     $cacheable->addCacheTags(['config:jsonapi_frontend.settings']);
-    $cacheable->applyTo($response);
+    $response->addCacheableDependency($cacheable);
 
     $this->applySecurityHeaders($response);
 
@@ -144,7 +144,7 @@ private function errorResponse(int $status, string $title, string $detail): Cach
 
     $cacheable = new CacheableMetadata();
     $cacheable->setCacheMaxAge(0);
-    $cacheable->applyTo($response);
+    $response->addCacheableDependency($cacheable);
     $this->applySecurityHeaders($response);
 
     return $response;

tests/src/Kernel/PathResolutionTest.php

@@ -9,6 +9,7 @@
 use Drupal\node\Entity\Node;
 use Drupal\node\Entity\NodeType;
 use Drupal\user\Entity\User;
+use Symfony\Component\HttpFoundation\Request;
 
 /**
  * Kernel tests for path resolution functionality.
@@ -195,4 +196,31 @@ public function testResolveInternalPath(): void {
     $this->assertEquals($node->uuid(), $result['entity']['id']);
   }
 
+  /**
+   * Tests the /jsonapi/resolve controller response.
+   */
+  public function testResolveControllerResponse(): void {
+    $node = Node::create([
+      'type' => 'page',
+      'title' => 'About Us',
+      'status' => 1,
+      'path' => ['alias' => '/about-us'],
+    ]);
+    $node->save();
+
+    $controller = \Drupal\jsonapi_frontend\Controller\PathResolverController::create($this->container);
+    $request = Request::create('/jsonapi/resolve', 'GET', [
+      'path' => '/about-us',
+      '_format' => 'json',
+    ]);
+
+    $response = $controller->resolve($request);
+    $payload = json_decode((string) $response->getContent(), TRUE);
+
+    $this->assertIsArray($payload);
+    $this->assertTrue($payload['resolved']);
+    $this->assertEquals('entity', $payload['kind']);
+    $this->assertEquals($node->uuid(), $payload['entity']['id']);
+  }
+
 }