Skip to content

Commit b9d1d7e

Browse files
committed
chore(utils): exclude empty issues from report
1 parent e213dd9 commit b9d1d7e

2 files changed

Lines changed: 11 additions & 19 deletions

File tree

packages/utils/src/lib/reports/__snapshots__/sorting.integration.test.ts.snap

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,6 @@ exports[`sortReport > should sort the audits and audit groups in categories, plu
8484
"value": 3,
8585
},
8686
{
87-
"details": {
88-
"issues": [],
89-
},
9087
"plugin": "cypress",
9188
"score": 1,
9289
"slug": "cypress-component-tests",
@@ -174,29 +171,20 @@ exports[`sortReport > should sort the audits and audit groups in categories, plu
174171
"value": 1,
175172
},
176173
{
177-
"details": {
178-
"issues": [],
179-
},
180174
"plugin": "eslint",
181175
"score": 1,
182176
"slug": "eslint-jest-consistent-naming",
183177
"title": "Consistent naming",
184178
"value": 0,
185179
},
186180
{
187-
"details": {
188-
"issues": [],
189-
},
190181
"plugin": "eslint",
191182
"score": 1,
192183
"slug": "eslint-cypress",
193184
"title": "Cypress rules",
194185
"value": 0,
195186
},
196187
{
197-
"details": {
198-
"issues": [],
199-
},
200188
"plugin": "eslint",
201189
"score": 1,
202190
"slug": "typescript-eslint-enums",

packages/utils/src/lib/reports/sorting.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,17 @@ export function sortReport(report: ScoredReport): ScoredReport {
5656

5757
const sortedPlugins = plugins.map(plugin => ({
5858
...plugin,
59-
audits: plugin.audits.sort(compareAudits).map(audit => ({
60-
...audit,
61-
details: {
62-
...audit.details,
63-
issues: [...(audit?.details?.issues ?? [])].sort(compareIssues),
64-
},
65-
})),
59+
audits: [...plugin.audits].sort(compareAudits).map(audit =>
60+
audit.details?.issues
61+
? {
62+
...audit,
63+
details: {
64+
...audit.details,
65+
issues: [...audit.details.issues].sort(compareIssues),
66+
},
67+
}
68+
: audit,
69+
),
6670
}));
6771

6872
return {

0 commit comments

Comments
 (0)