test(core): simplify mocks

Author: Tlacenka

packages/core/src/lib/collect-and-persist.unit.test.ts

@@ -8,42 +8,32 @@ import { collectAndPersistReports } from './collect-and-persist';
 import { collect } from './implementation/collect';
 import { logPersistedResults, persistReport } from './implementation/persist';
 
-vi.mock('./implementation/collect', async () => {
-  return {
-    collect: vi.fn().mockImplementation(
-      async () =>
-        ({
-          packageName: 'code-pushup',
-          version: '0.0.1',
-          date: new Date().toISOString(),
-          duration: 0,
-          categories: [],
-          plugins: [],
-        } as Report),
-    ),
-  };
-});
+vi.mock('./implementation/collect', () => ({
+  collect: vi.fn().mockResolvedValue({
+    packageName: 'code-pushup',
+    version: '0.0.1',
+    date: new Date().toISOString(),
+    duration: 0,
+    categories: [],
+    plugins: [],
+  } as Report),
+}));
 
-vi.mock('./implementation/persist', async () => {
-  return {
-    persistReport: vi.fn().mockImplementation(async () => ({})),
-    logPersistedResults: vi.fn().mockReturnValue(undefined),
-  };
-});
+vi.mock('./implementation/persist', () => ({
+  persistReport: vi.fn(),
+  logPersistedResults: vi.fn(),
+}));
 
 describe('collectAndPersistReports', () => {
   it('should call collect and persistReport with correct parameters in non-verbose mode', async () => {
-    await collectAndPersistReports({
+    const nonVerboseConfig = {
       ...MINIMAL_CONFIG_MOCK,
       verbose: false,
       progress: false,
-    });
+    };
+    await collectAndPersistReports(nonVerboseConfig);
 
-    expect(collect).toHaveBeenCalledWith({
-      ...MINIMAL_CONFIG_MOCK,
-      verbose: false,
-      progress: false,
-    });
+    expect(collect).toHaveBeenCalledWith(nonVerboseConfig);
 
     expect(persistReport).toHaveBeenCalledWith(
       {
@@ -54,28 +44,21 @@ describe('collectAndPersistReports', () => {
         categories: [],
         plugins: [],
       },
-      {
-        ...MINIMAL_CONFIG_MOCK,
-        verbose: false,
-        progress: false,
-      },
+      nonVerboseConfig,
     );
 
     expect(logPersistedResults).not.toHaveBeenCalled();
   });
 
   it('should call collect and persistReport with correct parameters in verbose mode', async () => {
-    await collectAndPersistReports({
+    const verboseConfig = {
       ...MINIMAL_CONFIG_MOCK,
       verbose: true,
       progress: false,
-    });
+    };
+    await collectAndPersistReports(verboseConfig);
 
-    expect(collect).toHaveBeenCalledWith({
-      ...MINIMAL_CONFIG_MOCK,
-      verbose: true,
-      progress: false,
-    });
+    expect(collect).toHaveBeenCalledWith(verboseConfig);
 
     expect(persistReport).toHaveBeenCalledWith(
       {
@@ -86,11 +69,7 @@ describe('collectAndPersistReports', () => {
         categories: [],
         plugins: [],
       } as Report,
-      {
-        ...MINIMAL_CONFIG_MOCK,
-        verbose: true,
-        progress: false,
-      },
+      verboseConfig,
     );
 
     expect(logPersistedResults).toHaveBeenCalled();

packages/core/src/lib/implementation/collect.integration.test.ts

@@ -29,7 +29,7 @@ describe('collect', () => {
     );
   });
 
-  it('should execute when no plugins are passed', async () => {
+  it('should throw when no plugins are passed', async () => {
     await expect(
       collect({
         ...MINIMAL_CONFIG_MOCK,

packages/core/src/lib/upload.unit.test.ts

@@ -6,7 +6,7 @@ import {
   ISO_STRING_REGEXP,
   MINIMAL_REPORT_MOCK,
 } from '@code-pushup/testing-utils';
-import { UploadOptions, upload } from './upload';
+import { upload } from './upload';
 
 describe('upload', () => {
   it('upload should be called with correct data', async () => {
@@ -31,9 +31,9 @@ describe('upload', () => {
         filename: 'report',
         format: ['json'],
       },
-    } as UploadOptions);
+    });
 
-    expect(result).toEqual({ packageName: '@code-pushup/cli' }); // TODO is this correct?
+    expect(result).toEqual({ packageName: '@code-pushup/cli' });
 
     expect(uploadToPortal).toHaveBeenCalledWith({
       apiKey: 'dummy-api-key',

testing-utils/src/lib/fixtures/configs/minimal-config.mock.ts

@@ -1,6 +1,6 @@
 import type {
+  AuditOutput,
   CoreConfig,
-  Issue,
   PluginConfig,
   RunnerConfig,
   RunnerFunction,
@@ -17,9 +17,6 @@ export const MINIMAL_RUNNER_CONFIG_MOCK: RunnerConfig = {
 export const MINIMAL_RUNNER_FUNCTION_MOCK: RunnerFunction = () => [
   {
     slug: 'node-version',
-    title: 'Node version',
-    description: 'Returns node version',
-    docsUrl: 'https://nodejs.org/',
     score: 0.3,
     value: 16,
     displayValue: '16.0.0',
@@ -28,10 +25,10 @@ export const MINIMAL_RUNNER_FUNCTION_MOCK: RunnerFunction = () => [
         {
           severity: 'error',
           message: 'The required Node version to run Code PushUp CLI is 18.',
-        } satisfies Issue,
+        },
       ],
     },
-  },
+  } satisfies AuditOutput,
 ];
 
 export const MINIMAL_PLUGIN_CONFIG_MOCK: PluginConfig = {
@@ -50,7 +47,7 @@ export const MINIMAL_PLUGIN_CONFIG_MOCK: PluginConfig = {
 };
 
 export const MINIMAL_CONFIG_MOCK: CoreConfig = {
-  persist: { outputDir: 'test', filename: 'report.json' },
+  persist: { outputDir: '/test', filename: 'report.json' },
   upload: {
     organization: 'code-pushup',
     project: 'cli',