chore(plugin-coverage): use universal paths in tests, fix lint

Author: Tlacenka

e2e/cli-e2e/.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "extends": ["../../.eslintrc.json"],
-  "ignorePatterns": ["!**/*", "code-pushup.config.*?.ts"],
+  "ignorePatterns": ["!**/*", "code-pushup.config*.ts"],
   "overrides": [
     {
       "files": ["*.ts", "*.tsx"],

e2e/cli-e2e/tests/collect.e2e.test.ts

@@ -1,4 +1,5 @@
-import { join } from 'node:path';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { PluginReport, Report, reportSchema } from '@code-pushup/models';
 import { cleanTestFolder } from '@code-pushup/testing-utils';
 import { executeProcess, readJsonFile, readTextFile } from '@code-pushup/utils';
@@ -52,8 +53,8 @@ describe('CLI collect', () => {
      */
 
     const configPath = join(
-      'e2e',
-      'cli-e2e',
+      fileURLToPath(dirname(import.meta.url)),
+      '..',
       'mocks',
       'fixtures',
       'code-pushup.config.coverage.ts',

packages/models/src/index.ts

@@ -19,26 +19,27 @@ export {
 } from './lib/core-config';
 export { Group, GroupRef, groupSchema } from './lib/group';
 export {
-  MAX_DESCRIPTION_LENGTH,
-  MAX_ISSUE_MESSAGE_LENGTH,
-  MAX_SLUG_LENGTH,
-  MAX_TITLE_LENGTH,
-} from './lib/implementation/limits';
+  CONFIG_FILE_NAME,
+  SUPPORTED_CONFIG_FILE_FORMATS,
+} from './lib/implementation/configuration';
 export {
   PERSIST_FILENAME,
-  PERSIST_OUTPUT_DIR,
   PERSIST_FORMAT,
+  PERSIST_OUTPUT_DIR,
 } from './lib/implementation/constants';
 export {
-  CONFIG_FILE_NAME,
-  SUPPORTED_CONFIG_FILE_FORMATS,
-} from './lib/implementation/configuration';
+  MAX_DESCRIPTION_LENGTH,
+  MAX_ISSUE_MESSAGE_LENGTH,
+  MAX_SLUG_LENGTH,
+  MAX_TITLE_LENGTH,
+} from './lib/implementation/limits';
 export {
   fileNameSchema,
   filePathSchema,
   materialIconSchema,
   urlSchema,
 } from './lib/implementation/schemas';
+export { exists } from './lib/implementation/utils';
 export {
   Format,
   PersistConfig,

packages/plugin-coverage/src/lib/runner/lcov/runner.integration.test.ts

@@ -1,4 +1,5 @@
-import { join } from 'node:path';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { describe, it } from 'vitest';
 import { lcovResultsToAuditOutputs } from './runner';
 
@@ -14,8 +15,11 @@ describe('lcovResultsToAuditOutputs', () => {
       [
         {
           resultsPath: join(
-            'packages',
-            'plugin-coverage',
+            fileURLToPath(dirname(import.meta.url)),
+            '..',
+            '..',
+            '..',
+            '..',
             'mocks',
             'single-record-lcov.info',
           ),

packages/plugin-coverage/src/lib/runner/lcov/runner.ts

@@ -1,14 +1,12 @@
 import { join } from 'node:path';
 import type { LCOVRecord } from 'parse-lcov';
 import { AuditOutputs } from '@code-pushup/models';
-import { readTextFile, toUnixPath } from '@code-pushup/utils';
-//TODO fix, why doesnt it know the exists import??
-import { exists } from '../../../../../models/src/lib/implementation/utils';
+import { exists, readTextFile } from '@code-pushup/utils';
 import { CoverageReport, CoverageType } from '../../config';
 import { parseLcov } from './parse-lcov';
 import {
   lcovCoverageToAuditOutput,
-  reportToStatFunctionMapper as recordToStatFunctionMapper,
+  recordToStatFunctionMapper,
 } from './transform';
 import { LCOVStat, LCOVStats } from './types';
 
@@ -26,20 +24,19 @@ export async function lcovResultsToAuditOutputs(
   coverageTypes: CoverageType[],
 ): Promise<AuditOutputs> {
   const parsedReports = await Promise.all(
-    reports.map(report =>
-      readTextFile(toUnixPath(report.resultsPath))
-        .then(reportContent => parseLcov(reportContent))
-        .then(records =>
-          records.map<LCOVRecord>(record => ({
-            ...record,
-            file:
-              report.pathToProject == null
-                ? record.file
-                : join(report.pathToProject, record.file),
-          })),
-        ),
-    ),
+    reports.map(async report => {
+      const reportContent = await readTextFile(report.resultsPath);
+      const parsedRecords = parseLcov(reportContent);
+      return parsedRecords.map<LCOVRecord>(record => ({
+        ...record,
+        file:
+          report.pathToProject == null
+            ? record.file
+            : join(report.pathToProject, record.file),
+      }));
+    }),
   );
+
   if (parsedReports.length !== reports.length) {
     throw new Error('Some provided LCOV reports were not valid.');
   }

packages/plugin-coverage/src/lib/runner/lcov/transform.ts

@@ -1,4 +1,3 @@
-/* eslint-disable max-lines-per-function */
 import { LCOVRecord } from 'parse-lcov';
 import { AuditOutput, Issue } from '@code-pushup/models';
 import { toUnixPath } from '@code-pushup/utils';
@@ -88,7 +87,7 @@ export function lcovReportToBranchStat(record: LCOVRecord): LCOVStat {
   };
 }
 
-export const reportToStatFunctionMapper = {
+export const recordToStatFunctionMapper = {
   branch: lcovReportToBranchStat,
   line: lcovReportToLineStat,
   function: lcovReportToFunctionStat,

packages/utils/src/index.ts

@@ -1,3 +1,4 @@
+export { exists } from '@code-pushup/models';
 export {
   ProcessConfig,
   ProcessError,
@@ -56,7 +57,6 @@ export {
   CliArgsObject,
   countOccurrences,
   distinct,
-  exists,
   factorOf,
   objectToCliArgs,
   objectToEntries,