test: move mocks to testing-utils, update tests

Author: Tlacenka

packages/core/src/lib/collect-and-persist.unit.test.ts

@@ -3,11 +3,11 @@ import {
   PERSIST_FILENAME,
   PERSIST_FORMAT,
   PERSIST_OUTPUT_DIR,
-  Report,
 } from '@code-pushup/models';
 import {
   ISO_STRING_REGEXP,
   MINIMAL_CONFIG_MOCK,
+  MINIMAL_REPORT_MOCK,
 } from '@code-pushup/testing-utils';
 import {
   CollectAndPersistReportsOptions,
@@ -18,14 +18,7 @@ import { logPersistedResults, persistReport } from './implementation/persist';
 import { normalizePersistConfig } from './normalize';
 
 vi.mock('./implementation/collect', () => ({
-  collect: vi.fn().mockResolvedValue({
-    packageName: 'code-pushup',
-    version: '0.0.1',
-    date: new Date().toISOString(),
-    duration: 0,
-    categories: [],
-    plugins: [],
-  } as Report),
+  collect: vi.fn().mockResolvedValue(MINIMAL_REPORT_MOCK),
 }));
 
 vi.mock('./implementation/persist', () => ({
@@ -66,12 +59,12 @@ describe('collectAndPersistReports', () => {
 
     expect(persistReport).toHaveBeenCalledWith(
       {
-        packageName: 'code-pushup',
+        packageName: '@code-pushup/core',
         version: '0.0.1',
         date: expect.stringMatching(ISO_STRING_REGEXP),
-        duration: 0,
-        categories: [],
-        plugins: [],
+        duration: 666,
+        categories: expect.any(Array),
+        plugins: expect.any(Array),
       },
       normalizePersistConfig(nonVerboseConfig.persist),
     );
@@ -90,14 +83,7 @@ describe('collectAndPersistReports', () => {
     expect(collect).toHaveBeenCalledWith(verboseConfig);
 
     expect(persistReport).toHaveBeenCalledWith(
-      {
-        packageName: 'code-pushup',
-        version: '0.0.1',
-        date: expect.stringMatching(ISO_STRING_REGEXP),
-        duration: 0,
-        categories: [],
-        plugins: [],
-      } as Report,
+      MINIMAL_REPORT_MOCK,
       normalizePersistConfig(verboseConfig.persist),
     );
 

packages/models/src/lib/report.unit.test.ts

@@ -1,4 +1,4 @@
-import { describe, it } from 'vitest';
+import { describe, expect, it } from 'vitest';
 import {
   AuditReport,
   PluginReport,

packages/models/test/fixtures/categories.mock.ts

@@ -11,6 +11,6 @@
     "vite.config.integration.ts",
     "src/**/*.test.ts",
     "src/**/*.mock.ts",
-    "test/**/*.ts"
+    "mocks/**/*.ts"
   ]
 }

packages/models/test/fixtures/code-pushup.config.mock.cjs

@@ -7,7 +7,7 @@
   "include": [
     "vite.config.unit.ts",
     "vite.config.integration.ts",
-    "test/**/*.ts",
+    "mocks/**/*.ts",
     "src/**/*.test.ts",
     "src/**/*.test.tsx",
     "src/**/*.test.js",

packages/models/test/fixtures/code-pushup.config.mock.ts

@@ -1,7 +1,7 @@
 import { defaultConfig } from 'lighthouse';
 import { join } from 'path';
 import { PluginConfig } from '@code-pushup/models';
-import { echoRunnerConfig } from '@code-pushup/models/testing';
+import { echoRunnerConfigMock } from '@code-pushup/testing-utils';
 
 type LighthousePluginConfig = {
   config: string;
@@ -23,7 +23,7 @@ export function lighthousePlugin(_: LighthousePluginConfig): PluginConfig {
         title: 'Largest Contentful Paint',
       },
     ],
-    runner: echoRunnerConfig(
+    runner: echoRunnerConfigMock(
       [
         {
           slug: 'largest-contentful-paint',