deployment fix?

Author: abrulic

.github/workflows/publish-documentation.yaml

@@ -32,6 +32,15 @@ jobs:
         working-directory: docs
         run: pnpm run generate:docs
 
+      - name: Upload generated docs artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: docs-generated
+          path: |
+            docs/generated-docs/**
+            docs/app/utils/versions.ts
+          if-no-files-found: error
+
   deploy:
     name: 🚀 Deploy Release
     needs: [build-docs]
@@ -40,6 +49,15 @@ jobs:
       name: docs-release
     steps:
       - uses: actions/checkout@v4
+      - name: Download generated docs
+        uses: actions/download-artifact@v4
+        with:
+          name: docs-generated
+          path: docs
+
+      # check TODO remove this 
+      - name: List generated payload
+        run: ls -laR docs/generated-docs | head -n 200
       - uses: forge-42/fly-deploy@v1.0.0-rc.2
         id: deploy
         env:

.github/workflows/validate.yaml

@@ -44,16 +44,58 @@ jobs:
       - name: 🔎 Validate
         run: pnpm run test
 
+
+  build-docs:
+    if: ${{ github.event_name == 'pull_request' }}
+    name: Build Docs
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: "package.json"
+          cache: "pnpm"
+
+      - name: Install deps
+        run: pnpm install --prefer-offline --frozen-lockfile
+
+      - name: Generate docs
+        working-directory: docs
+        run: pnpm run generate:docs
+
+      - name: Upload generated docs artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: docs-generated
+          path: |
+            docs/generated-docs/**
+            docs/app/utils/versions.ts
+          if-no-files-found: error
+
   deploy-docs-pr-preview:
     if: ${{ github.event_name == 'pull_request' }}
-    name: "🚀 Deploy Docs"
-    needs: [lint, validate]
+    name: 🚀 Deploy Docs
+    needs: [lint, validate, build-docs] 
     runs-on: ubuntu-latest
     environment:
       name: docs-release
-      url: ${{ steps.deploy.outputs.app_url }}
     steps:
       - uses: actions/checkout@v4
+      - name: Download generated docs
+        uses: actions/download-artifact@v4
+        with:
+          name: docs-generated
+          path: docs
+
+      # check TODO remove this
+      - name: List generated payload
+        run: ls -laR docs/generated-docs | head -n 200
       - uses: forge-42/fly-deploy@v1.0.0-rc.2
         id: deploy
         env:

docs/Dockerfile

@@ -1,51 +1,41 @@
-
 # syntax = docker/dockerfile:1.4
 
-# Base dependencies stage
 ARG NODE_VERSION=22.17.0
 FROM node:${NODE_VERSION}-slim AS base
 
 LABEL fly_launch_runtime="Node.js"
-
-# Node.js app lives here
 WORKDIR /app
+ENV NODE_ENV=production
 
-# Set production environment
-ENV NODE_ENV="production"
-
-# Install pnpm
 ARG PNPM_VERSION=10.18.0
 RUN npm install -g pnpm@$PNPM_VERSION
 
-
-# Throw-away build stage to reduce size of final image
+# --- Build stage ---
 FROM base AS build
 
-# Install packages needed to build node modules
+# System deps only if you have native modules; otherwise you can drop this
 RUN apt-get update -qq && \
-    apt-get install --no-install-recommends -y build-essential node-gyp pkg-config python-is-python3 git
+    apt-get install --no-install-recommends -y build-essential node-gyp pkg-config python-is-python3 && \
+    rm -rf /var/lib/apt/lists/*
 
-# Install node modules
+# Install deps
 COPY .npmrc package.json ./
 RUN pnpm install --prod=false
 
-# Copy application code
+# Copy the application (including the previously downloaded artifact under docs/)
 COPY . .
 
-# Build application
-RUN pnpm run generate:docs
+# IMPORTANT: we no longer generate docs here; they were provided by CI
+# Build the app (should read from docs/generated-docs/* and versions.ts that CI uploaded)
 RUN pnpm run build
 
-# Remove development dependencies
+# Prune dev deps
 RUN pnpm prune --prod
 
-
-# Final stage for app image
+# --- Runtime stage ---
 FROM base
 
-# Copy built application
 COPY --from=build /app /app
 
-# Start the server by default, this can be overwritten at runtime
 EXPOSE 3000
-CMD [ "pnpm", "run", "start" ]
+CMD ["pnpm","run","start"]