Commit b73f32e
Address review feedback: remove ERR trap, use printf over echo
- Remove ERR trap from test file — doesn't fire inside functions
without errtrace, consistent with test_helpers.sh (PR #13).
- Use printf '%s\n' instead of echo for piping match string to
sed, avoiding issues with -n or escape sequences.
Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>1 parent 1d815b8 commit b73f32e
2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
0 commit comments