Update Ready State when Offboarded

One rarely sees it, but if offboarding is completed
and the hypervisor doesn't get deleted one only sees
ScaleDown and that makes it harder to narrow down
where it is stuck.

Author: fwiesel

internal/controller/decomission_controller.go

@@ -175,6 +175,12 @@ func (r *NodeDecommissionReconciler) markOffboarded(ctx context.Context, hv *kvm
 		Reason:  "Offboarded",
 		Message: "Offboarding successful",
 	})
+	meta.SetStatusCondition(&hv.Status.Conditions, metav1.Condition{
+		Type:    kvmv1.ConditionTypeReady,
+		Status:  metav1.ConditionFalse,
+		Reason:  "Offboarded",
+		Message: "Offboarding successful",
+	})
 	if err := r.Status().Patch(ctx, hv, k8sclient.MergeFromWithOptions(base,
 		k8sclient.MergeFromWithOptimisticLock{}), k8sclient.FieldOwner(DecommissionControllerName)); err != nil {
 		return fmt.Errorf("cannot update hypervisor status due to %w", err)

internal/controller/decomission_controller_test.go

@@ -242,10 +242,18 @@ var _ = Describe("Decommission Controller", func() {
 
 					hypervisor := &kvmv1.Hypervisor{}
 					Expect(k8sClient.Get(ctx, resourceName, hypervisor)).To(Succeed())
-					Expect(hypervisor.Status.Conditions).To(ContainElement(
+					Expect(hypervisor.Status.Conditions).To(ContainElements(
 						SatisfyAll(
 							HaveField("Type", kvmv1.ConditionTypeOffboarded),
 							HaveField("Status", metav1.ConditionTrue),
+							HaveField("Reason", "Offboarded"),
+							HaveField("Message", "Offboarding successful"),
+						),
+						SatisfyAll(
+							HaveField("Type", kvmv1.ConditionTypeReady),
+							HaveField("Status", metav1.ConditionFalse),
+							HaveField("Reason", "Offboarded"),
+							HaveField("Message", "Offboarding successful"),
 						),
 					))
 				})