Skip to content
This repository was archived by the owner on Jan 31, 2022. It is now read-only.
This repository was archived by the owner on Jan 31, 2022. It is now read-only.

Update calibrateArmDac.sh to dump all VFAT config info to log file #17

@bdorney

Description

@bdorney

Brief summary of issue

Right now calibrateArmDac.sh only dumps VFAT0 configuration to log file. This is a problem because:

  1. This VFAT could be masked, and
  2. The DAC values of each VFAT could be different (e.g. after DAC scans).

Types of issue

  • Bug report (report an issue with the code)
  • Feature request (request for change which adds functionality)

Expected Behavior

All VFAT settings are written to log file.

Current Behavior

Only VFAT0 is written to log file.

Possible Solution (for bugs)

This line should be executed inside of a loop over all VFATs:

echo "Writing configuration for CFG_THR_ARM_DAC=${armDacVal} to file"
echo "gem_reg.py -n ${CARDNAME} -e kw 'GEM_AMC.OH.OH${LINK}.GEB.VFAT0.CFG_' 2>&1 | tee -a scurveLog_ArmDac_${armDacVal}.txt"
echo "Configuration of All VFATs:" 2>&1 | tee -a scurveLog_ArmDac_${armDacVal}.txt
gem_reg.py -n ${CARDNAME} -e kw "GEM_AMC.OH.OH${LINK}.GEB.VFAT0.CFG_" 2>&1 | tee -a scurveLog_ArmDac_${armDacVal}.txt
sleep 1

Context (for feature requests)

For evaluating scan settings it is important to have all info in the log file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions