Relvals getting approved even after local test failure

[pkalbhor]

At approval stage, relval config files are locally executed for few events that we call local test. After successful local test, status of relval changes from approving to approved. In case of any failure, non-zero code is returned and status of the relval changes back to new.

Issue: Even after failure of local test, status code of the execution script is getting returned as 0 (meaning successful local test). See this example of local test here [1]. Which mean relvals are getting approved even if there is some error.

Hint: Need to make sure exit codes are correctly saved to the database. Exit codes are saved to database from here. Issue arose due to last couple of commits to the relval_test_submitter.py

[1] https://alcaval.web.cern.ch/relvals/local_test_result/CMSSW_12_4_11__TrkAl-HLTNew-ExpressPhysicsRun2022F-00003