Azure credentials secret uses incorrect Values path

[vi-malii]

There is a configuration mismatch in the helm template for Azure replica credentials:
File: helm/postgresql-cluster/templates/origin-azure-creds.yaml
Secret data fields read values from: .Values.recovery.azure.* instead of the replica configuration path

File: helm/postgresql-cluster/templates/recovery-azure-creds.yaml
Secret data fields read also from .Values.recovery.azure.*

and one more thing, there are backup-azure-creds and recovery-azure-creds, but then suddenly origin-azure-creds, which is is slightly confusing

[dosubot]

Hi @vi-malii! I'm Dosu and I’m helping the charts team.

You're right on both points. This is a confirmed copy-paste bug introduced when replica cluster support was added in PR #576.

The Values path issue: origin-azure-creds.yaml uses .Values.recovery.azure.* [1] but should use .Values.replica.origin.objectStore.azure.* — which is already defined in the values schema [2]. This means the generated secret ends up with blank credentials in replica mode because recovery values are empty in that context.

The same bug also affects the S3 and Google origin credential templates.

Existing fix: PR #806 was opened to fix this for all three cloud providers but hasn't been merged yet.

On the naming: The convention is backup-*-creds, recovery-*-creds, and origin-*-creds — "origin" refers to the replica's origin object store. It is a different naming pattern from the other two, which mirror their values path prefix (backups.* → backup-*-creds, recovery.* → recovery-*-creds). Renaming to something like replica-azure-creds could be clearer, though that would be a separate discussion.

To reply, just mention @dosu.

---

Share context across your team and agents. Try Dosu.