Skip to content

Commit c1930d3

Browse files
Refactor - Rename Values to Qualifiers (#339)
1 parent ea3fbdc commit c1930d3

File tree

186 files changed

+919
-922
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

186 files changed

+919
-922
lines changed

DOCS.README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ console.log(myURL);
4343

4444
```
4545

46-
## Passing values to Actions
46+
## Passing Qualifiers to Actions
4747

4848
<div>
4949
We've just seen an example of how to scale our image.<br/>
50-
This example used width and height, and passed some numeric values as parameters.<br/><br/>
50+
This example used width and height, and passed some numeric qualifiers as parameters.<br/><br/>
5151
In the SDK world, we refer to methods on an Action as Qualifiers.<br/><br/>
5252
The ResizeScale action has a width and height Qualifier.<br/>
5353
Qualifiers receive QualifierValues as parameters.
@@ -75,7 +75,7 @@ const cld = new Cloudinary({
7575
import {mode} from '@cloudinary/base/actions/rotate';
7676

7777
// Import the RotationModeAction
78-
import {RotationMode} from '@cloudinary/base/values';
78+
import {RotationMode} from '@cloudinary/base/qualifiers';
7979

8080
const myImage = cld.image('sample');
8181

__DOC_EXAMPLES__/annotatedExamples/imageOverlay.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ const myImage = cld.image('sample');
1919
// Import video or image overlay, based on your asset
2020
import {Overlay} from "@cloudinary/base/actions/overlay";
2121
// Import the source of the layer, this determines if the layer is an image, text or video
22-
import {image} from "@cloudinary/base/values/source";
22+
import {image} from "@cloudinary/base/qualifiers/source";
2323

2424
// Import how to position your layer
25-
import {Position} from "@cloudinary/base/values/position";
26-
import {southEast} from "@cloudinary/base/values/gravity/qualifiers/compass/Compass";
27-
import {compass} from "@cloudinary/base/values/gravity";
25+
import {Position} from "@cloudinary/base/qualifiers/position";
26+
import {southEast} from "@cloudinary/base/qualifiers/gravity/qualifiers/compass/Compass";
27+
import {compass} from "@cloudinary/base/qualifiers/gravity";
2828

2929
// We'll also scale our overlay, we'll need this for later.
3030
import {scale} from "@cloudinary/base/actions/resize";

__DOC_EXAMPLES__/annotatedExamples/rotate.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ import {mode} from '@cloudinary/base/actions/rotate';
2020
// The RotationModeAction (mode) requires a Qualifier
2121
// That qualifier will require a certain QualifierValue
2222
// To make life easier, you can import all possible QualifierValue(s) of rotate
23-
import {RotationMode} from '@cloudinary/base/values/rotationMode';
23+
import {RotationMode} from '@cloudinary/base/qualifiers/rotationMode';
2424

2525
// You can also import only the required QualifierValue you want
26-
import {verticalFlip} from '@cloudinary/base/values/rotationMode';
26+
import {verticalFlip} from '@cloudinary/base/qualifiers/rotationMode';
2727
// RotationMode.verticalFlip === verticalFlip
2828

2929
const myImage = cld.image('sample');

__DOC_EXAMPLES__/gettingStarted/terminology.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import {Cloudinary} from "@cloudinary/base/instance/Cloudinary";
88
import {Rotate} from "@cloudinary/base/actions/rotate";
99
import {Resize} from "@cloudinary/base/actions/resize";
10-
import {RotationMode} from "@cloudinary/base/values/RotationMode";
10+
import {RotationMode} from "@cloudinary/base/qualifiers/RotationMode";
1111

1212
// Create your instance
1313
const cld = new Cloudinary({

__DOC_EXAMPLES__/gettingStarted/treeShaking.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ Everything can be very granularly imported to ensure you only import what you ne
3737
<h4>Without Tree-Shaking</h4>
3838

3939
```javascript
40-
import {Format} from "@cloudinary/base/values/format";
40+
import {Format} from "@cloudinary/base/qualifiers/format";
4141

4242
Format.png()
4343
Format.jpg()
4444
```
4545
<h4>With Tree-Shaking</h4>
4646

4747
```javascript
48-
import {jpg, png} from "@cloudinary/base/values/format";
48+
import {jpg, png} from "@cloudinary/base/qualifiers/format";
4949

5050
png()
5151
jpg()

__TESTS_BUNDLE_SIZE__/bundleSizeTestCases.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const bundleSizeTestCases:ITestCase[] = [
6060
importsArray: [
6161
importFromDist('assets/CloudinaryImage', 'CloudinaryImage'),
6262
importFromDist('actions/overlay', 'Overlay'),
63-
importFromDist('values/source', 'Source'),
63+
importFromDist('qualifiers/source', 'Source'),
6464
importFromDist('transformation/Transformation', 'Transformation'),
6565
importFromDist('actions/resize', 'crop')
6666
]

__TESTS__/TestUtils/transformations/sampleEmptyTextStyle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {TextStyle} from "../../../src/values/textStyle";
1+
import {TextStyle} from "../../../src/qualifiers/textStyle";
22

33
/**
44
* Creates an empty TextStyle instance used for testing

__TESTS__/TestUtils/transformations/sampleFacePosition.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import {Position} from "../../../src/values/position";
2-
import {Gravity} from "../../../src/values/gravity";
3-
import {FocusOn} from "../../../src/values/focusOn";
1+
import {Position} from "../../../src/qualifiers/position";
2+
import {Gravity} from "../../../src/qualifiers/gravity";
3+
import {FocusOn} from "../../../src/qualifiers/focusOn";
44

55
/**
66
* sample action used for testing

__TESTS__/TestUtils/transformations/sampleTextStyle.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import {TextStyle} from "../../../src/values/textStyle";
2-
import {FontAntialias} from "../../../src/values/FontAntialias";
3-
import {FontWeight} from "../../../src/values/fontWeight";
4-
import {FontHinting} from "../../../src/values/fontHinting";
5-
import {TextDecoration} from "../../../src/values/textDecoration";
6-
import {TextAlignment} from "../../../src/values/textAlignment";
7-
import {FontStyle} from "../../../src/values/fontStyle";
1+
import {TextStyle} from "../../../src/qualifiers/textStyle";
2+
import {FontAntialias} from "../../../src/qualifiers/FontAntialias";
3+
import {FontWeight} from "../../../src/qualifiers/fontWeight";
4+
import {FontHinting} from "../../../src/qualifiers/fontHinting";
5+
import {TextDecoration} from "../../../src/qualifiers/textDecoration";
6+
import {TextAlignment} from "../../../src/qualifiers/textAlignment";
7+
import {FontStyle} from "../../../src/qualifiers/fontStyle";
88

99
/**
1010
* Creates a TextStyle instance used for testing

__TESTS__/unit/Action/Action.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {Action} from '../../../src/internal/Action';
22
import {Qualifier} from '../../../src/internal/qualifier/Qualifier';
33
import {QualifierValue} from "../../../src/internal/qualifier/QualifierValue";
4-
import {FlagQualifier} from "../../../src/values/flag/FlagQualifier";
4+
import {FlagQualifier} from "../../../src/qualifiers/flag/FlagQualifier";
55
import {createNewImage} from "../../TestUtils/createCloudinaryImage";
66

77

0 commit comments

Comments
 (0)