add dither fromJson

Author: strausr

__TESTS__/unit/fromJson/effect.fromJson.test.ts

@@ -21,7 +21,8 @@ describe('effect.fromJson', () => {
       { actionType: 'loop', iterations: 5 },
       { actionType: 'makeTransparent', tolerance: 5, color: 'red' },
       { actionType: 'noise', level: 50 },
-      { actionType: 'vignette', level: 5 }
+      { actionType: 'vignette', level: 5 },
+      { actionType: 'dither', type: 9 }
 
     ]);
 
@@ -44,7 +45,8 @@ describe('effect.fromJson', () => {
       'e_loop:5',
       'co_red,e_makeTransparent:5',
       'e_noise:50',
-      'e_vignette:5'
+      'e_vignette:5',
+      'e_dither:9'
     ].join('/'));
   });
 });

__TESTS__/unit/toJson/effect.toJson.test.ts

@@ -202,7 +202,7 @@ describe('Effect toJson()', () => {
       .addAction(Effect.dither().type(halftone4x4Orthogonal()));
     expect(transformation.toJson()).toStrictEqual( [
       {
-        actionType: 'Dither',
+        actionType: 'dither',
         type: 9,
       }
     ]);

src/actions/effect/Dither.ts

@@ -1,5 +1,6 @@
 import {LeveledEffectAction} from "./EffectActions/LeveledEffectAction.js";
 import {IDitherModel} from "../../internal/models/IEffectActionModel.js";
+import {IActionModel} from "../../internal/models/IActionModel.js";
 
 /**
  * @description Applies an ordered dither filter to the image.
@@ -8,7 +9,7 @@ import {IDitherModel} from "../../internal/models/IEffectActionModel.js";
  * @see Visit {@link Actions.Effect|Effect} for an example
  */
 class DitherEffectAction extends LeveledEffectAction {
-  protected _actionModel: IDitherModel = {actionType: 'Dither'};
+  protected _actionModel: IDitherModel = {actionType: 'dither'};
   /**
    *
    * @param {Qualifiers.Dither} ditherType - The dither type applied to the image
@@ -20,6 +21,17 @@ class DitherEffectAction extends LeveledEffectAction {
     this.addQualifier(qualifierEffect);
     return this;
   }
+
+  static fromJson(actionModel: IActionModel): DitherEffectAction {
+    const {actionType, type} = (actionModel as IDitherModel);
+
+    // We are using this() to allow inheriting classes to use super.fromJson.apply(this, [actionModel])
+    // This allows the inheriting classes to determine the class to be created
+    const result = new this(actionType);
+    type && result.type(type);
+
+    return result;
+  }
 }
 
 

src/internal/fromJson.ts

@@ -30,6 +30,7 @@ import {BlackwhiteEffectAction} from "../actions/effect/leveled/Blackwhite.js";
 import {AccelerationEffectAction} from "../actions/effect/leveled/Accelerate.js";
 import {LoopEffectAction} from "../actions/effect/leveled/Loop.js";
 import {MakeTransparentEffectAction} from "../actions/effect/leveled/MakeTransparent.js";
+import {DitherEffectAction} from "../actions/effect/Dither.js";
 
 const ActionModelMap: Record<string, IHasFromJson> = {
   scale: ResizeScaleAction,
@@ -65,7 +66,9 @@ const ActionModelMap: Record<string, IHasFromJson> = {
   loop: LoopEffectAction,
   makeTransparent: MakeTransparentEffectAction,
   noise: EffectActionWithLevel,
-  vignette: EffectActionWithStrength
+  vignette: EffectActionWithStrength,
+  dither: DitherEffectAction
+
 };
 
 /**