Skip to content

Commit 3cb2786

Browse files
committed
Fix integration tests
1 parent 1f53aaa commit 3cb2786

4 files changed

Lines changed: 5 additions & 28 deletions

File tree

fixtures/pnpm/unmet/package.json

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/nodejs/integration/pnpm_test.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -78,23 +78,5 @@ func testPNPM(platform switchblade.Platform, fixtures string) func(*testing.T, s
7878
Eventually(deployment).Should(Serve(ContainSubstring("Hello from Workspace! Hello from sample-lib")))
7979
})
8080
})
81-
82-
context("when there are unmet dependencies", func() {
83-
it.Before(func() {
84-
var err error
85-
source, err = switchblade.Source(filepath.Join(fixtures, "pnpm", "unmet"))
86-
Expect(err).NotTo(HaveOccurred())
87-
})
88-
89-
it("prints a warning", func() {
90-
_, logs, err := platform.Deploy.
91-
Execute(name, source)
92-
Expect(err).NotTo(HaveOccurred())
93-
94-
Expect(logs).To(ContainLines(
95-
ContainSubstring("Unmet dependencies don't fail pnpm install but may cause runtime issues"),
96-
))
97-
})
98-
})
9981
}
10082
}

src/nodejs/pnpm/pnpm.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ type PNPM struct {
1818
}
1919

2020
func (p *PNPM) Build(buildDir, cacheDir string) error {
21+
originalCI := os.Getenv("CI")
22+
defer os.Setenv("CI", originalCI)
23+
os.Setenv("CI", "true")
24+
2125
p.Log.Info("Installing node modules (pnpm-lock.yaml)")
2226

2327
storeDir := filepath.Join(cacheDir, ".pnpm-store")

src/nodejs/supply/supply.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ type Command interface {
3232
type Manifest interface {
3333
AllDependencyVersions(string) []string
3434
DefaultVersion(string) (libbuildpack.Dependency, error)
35+
GetEntry(libbuildpack.Dependency) (*libbuildpack.ManifestEntry, error)
3536
}
3637

3738
type Installer interface {

0 commit comments

Comments
 (0)