From 047bd88909c2021b4eae5cfc8069d1c2dc55edc1 Mon Sep 17 00:00:00 2001 From: Peter Chen Date: Thu, 7 May 2026 12:32:18 -0700 Subject: [PATCH] refactor: remove unused code - func readable_route_dataset is not used --- lib/cloud_controller/permissions.rb | 8 --- .../lib/cloud_controller/permissions_spec.rb | 50 ------------------- 2 files changed, 58 deletions(-) diff --git a/lib/cloud_controller/permissions.rb b/lib/cloud_controller/permissions.rb index c77c72ba32d..319a0a300a4 100644 --- a/lib/cloud_controller/permissions.rb +++ b/lib/cloud_controller/permissions.rb @@ -213,14 +213,6 @@ def can_read_from_isolation_segment?(isolation_segment) can_read_globally? || readable_org_guids_query.where(isolation_segment_models: isolation_segment).any? end - def readable_route_dataset - if can_read_globally? - VCAP::CloudController::Route.dataset - else - VCAP::CloudController::Route.user_visible(@user, can_read_globally?) - end - end - def readable_services_space_guids if can_read_secrets_globally? VCAP::CloudController::Space.select_map(:guid) diff --git a/spec/unit/lib/cloud_controller/permissions_spec.rb b/spec/unit/lib/cloud_controller/permissions_spec.rb index 5ee1627b727..57fa1739f2b 100644 --- a/spec/unit/lib/cloud_controller/permissions_spec.rb +++ b/spec/unit/lib/cloud_controller/permissions_spec.rb @@ -902,56 +902,6 @@ module VCAP::CloudController end end - describe '#readable_route_dataset' do - it 'returns all the routes for admins' do - user = set_current_user_as_admin - subject = Permissions.new(user) - - org1 = Organization.make - space1 = Space.make(organization: org1) - route1 = Route.make(space: space1) - route2 = Route.make(space: space1) - org2 = Organization.make - space2 = Space.make(organization: org2) - route3 = Route.make(space: space2) - - dataset = subject.readable_route_dataset - - expect(dataset.first(guid: route1.guid)).to be_present - expect(dataset.first(guid: route2.guid)).to be_present - expect(dataset.first(guid: route3.guid)).to be_present - end - - it 'returns routes where the user has an appropriate org membership' do - manager_org = Organization.make - manager_space = Space.make(organization: manager_org) - manager_route = Route.make(space: manager_space) - manager_org.add_manager(user) - - auditor_org = Organization.make - auditor_space = Space.make(organization: auditor_org) - auditor_route = Route.make(space: auditor_space) - auditor_org.add_auditor(user) - - billing_manager_org = Organization.make - billing_manager_space = Space.make(organization: billing_manager_org) - billing_manager_route = Route.make(space: billing_manager_space) - billing_manager_org.add_billing_manager(user) - - member_org = Organization.make - member_space = Space.make(organization: member_org) - member_route = Route.make(space: member_space) - member_org.add_user(user) - - dataset = permissions.readable_route_dataset - - expect(dataset.first(guid: manager_route.guid)).to be_present - expect(dataset.first(guid: auditor_route.guid)).to be_present - expect(dataset.first(guid: billing_manager_route.guid)).to be_nil - expect(dataset.first(guid: member_route.guid)).to be_nil - end - end - describe '#can_read_route?' do it 'returns true if user is an admin' do set_current_user(user, { admin: true })