CLJS-2272: Tests that depended on default install deps behavior failing

Author: anmonteiro

script/test

@@ -12,7 +12,7 @@ mkdir -p builds/out-adv
 possible=5
 ran=0
 
-if ! bin/cljsc src/test/cljs "{:optimizations :advanced :output-wrapper true :verbose true :compiler-stats true :parallel-build true :output-dir \"builds/out-adv\" :npm-deps {:lodash \"4.17.4\"} :closure-warnings {:non-standard-jsdoc :off :global-this :off} :foreign-libs [{:file \"src/test/cljs/calculator_global.js\" :provides [\"calculator\"] :global-exports {calculator Calculator}}]}" > builds/out-adv/core-advanced-test.js; then
+if ! bin/cljsc src/test/cljs "{:optimizations :advanced :output-wrapper true :verbose true :compiler-stats true :parallel-build true :output-dir \"builds/out-adv\" :npm-deps {:lodash \"4.17.4\"} :closure-warnings {:non-standard-jsdoc :off :global-this :off} :install-deps true :foreign-libs [{:file \"src/test/cljs/calculator_global.js\" :provides [\"calculator\"] :global-exports {calculator Calculator}}]}" > builds/out-adv/core-advanced-test.js; then
   >&2 echo ClojureScript compilation failed
   exit 1
 fi;

script/test-simple

@@ -12,7 +12,7 @@ possible=5
 ran=0
 
 #bin/cljsc test >out/core-test.js
-if ! bin/cljsc src/test/cljs  "{:optimizations :simple :static-fns true :output-dir \"builds/out-simp\" :cache-analysis true :output-wrapper true :verbose true :compiler-stats true :npm-deps {:lodash \"4.17.4\"} :closure-warnings {:non-standard-jsdoc :off :global-this :off} :foreign-libs [{:file \"src/test/cljs/calculator_global.js\" :provides [\"calculator\"] :global-exports {calculator Calculator}}]}" > builds/out-simp/core-simple-test.js; then
+if ! bin/cljsc src/test/cljs  "{:optimizations :simple :static-fns true :output-dir \"builds/out-simp\" :cache-analysis true :output-wrapper true :verbose true :compiler-stats true :npm-deps {:lodash \"4.17.4\"} :closure-warnings {:non-standard-jsdoc :off :global-this :off} :install-deps true :foreign-libs [{:file \"src/test/cljs/calculator_global.js\" :provides [\"calculator\"] :global-exports {calculator Calculator}}]}" > builds/out-simp/core-simple-test.js; then
   >&2 echo ClojureScript compilation failed
   exit 1
 fi;

src/test/clojure/cljs/build_api_tests.clj

@@ -216,6 +216,7 @@
                                  :opts {:main 'npm-deps-test.core
                                         :output-dir out
                                         :optimizations :none
+                                        :install-deps true
                                         :npm-deps {:left-pad "1.1.3"}
                                         :closure-warnings {:check-types :off}}}
           cenv (env/default-compiler-env)]
@@ -229,6 +230,7 @@
                                :opts {:main 'npm-deps-test.string-requires
                                       :output-dir out
                                       :optimizations :none
+                                      :install-deps true
                                       :npm-deps {:react "15.6.1"
                                                  :react-dom "15.6.1"
                                                  :lodash "4.17.4"}
@@ -298,6 +300,7 @@
                                         :output-dir out
                                         :optimizations :none
                                         :target :nodejs
+                                        :install-deps true
                                         :npm-deps {:react "15.6.1"
                                                    :react-dom "15.6.1"}
                                         :closure-warnings {:check-types :off