Skip to content

Commit be69067

Browse files
clockwork-labs-botJulienLavocat
authored andcommitted
Avoid .NET globalization crash in LLM benchmarks (#5335)
# Description of Changes Sets `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1` only on the benchmark harness command that publishes generated C# modules. This keeps dotnet startup out of localized DateTime/TimeZoneInfo formatting on the CI runner, which was crashing before generated C# module publish could run. Stacked on #5324. ```bash gh workflow run llm-benchmark-periodic.yml \ --repo ClockworkLabs/SpacetimeDB \ --ref bot/debug-llm-csharp-publish \ -f model_set=explicit \ -f models="openrouter:openai/gpt-5.4-mini" \ -f languages=rust,csharp,typescript \ -f modes=guidelines \ -f tasks=t_000_empty_reducers \ -f dry_run=true ``` # API and ABI breaking changes None. # Expected complexity level and risk 1. CI benchmark harness environment fix. # Testing - [x] `cargo fmt --all` - [x] `cargo check --manifest-path tools/xtask-llm-benchmark/Cargo.toml` - [x] `ruby -e 'require "yaml"; YAML.load_file(".github/workflows/llm-benchmark-periodic.yml"); YAML.load_file(".github/workflows/llm-benchmark-validate-goldens.yml")'`\n- [x] `git diff --check` --------- Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com>
1 parent 34731d9 commit be69067

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

tools/xtask-llm-benchmark/src/bench/publishers.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,10 @@ impl DotnetPublisher {
330330
fn configure_dotnet_env(cmd: &mut Command) -> &mut Command {
331331
cmd.env("DOTNET_CLI_TELEMETRY_OPTOUT", "1")
332332
.env("DOTNET_NOLOGO", "1")
333+
// The CI runner's .NET install can crash while formatting localized
334+
// DateTime/TimeZoneInfo data before publish starts. Force invariant
335+
// globalization so generated C# module publish reaches MSBuild.
336+
.env("DOTNET_SYSTEM_GLOBALIZATION_INVARIANT", "1")
333337
// Prevent MSBuild node reuse issues that cause "Pipe is broken" errors
334338
// when running multiple dotnet builds in parallel.
335339
.env("MSBUILDDISABLENODEREUSE", "1")

0 commit comments

Comments
 (0)