cya does not handle directory names with spaces

[cspaniard]

The following setting makes cya fail.

BACKUP_DIRECTORIES="/sys/ /home/dsanroma/directory with spaces/"

[...]
/sys/ ... yes
/home/dsanroma/directory ... skipping - DOESN'T EXIST!
with ... skipping - DOESN'T EXIST!
spaces/ ... skipping - DOESN'T EXIST!
[...]

Similar things happen with MYDATA_xxxx settings with spaces in them.

Maybe the string could be broken up with regex instead of just white spaces.

just a though

[cleverwise]

Have you tried putting a back slash?

/home/dsanroma/directory\ with\ spaces/

[cspaniard]

Yes I did... no dice... ;(

[cleverwise]

Okay. Well that needs to be patched and honestly has the highest priority out of all these issues.

[cspaniard]

Makes sense, of course... Bugs first, features later... ;)

I will keep on testing different things and scenarios...

[cleverwise]

All you need to do is try \\

/home/dsanroma/directory\\ with\\ spaces/

[cleverwise]

The double slashes got edited by github (makes sense) so in case you only check email first and not my revised post it is backslash backslash together or double backslashes. That will allow a slash to occur and spaces to work.

So /directory(backslashbackslashspace)with(backslashbackslashspace)spaces/

[cspaniard]

Tested and it works!!!!
the /home/dsanroma/directory\\ with\\ spaces/ syntax works great!!!

Since it is not all that intuitive to have to "escape twice", maybe the syntax could be explained / specified in the cya configfile command.

What do you think ?

[cleverwise]

Yeah I already added it to the configfile information in 2.3.1+ dev/2.4

[cleverwise]

I added the question label since there is nothing to change code wise. Also using labels to keep track of what has been done. You have been emailed a dev copy 2.3.1 for the three enhancements.

[cspaniard]

Checks that "double-back-slash explanation" is present in:

BACKUP_DIRECTORIES Explanation and Examples, both documented
EXCLUDE_/xxxx/ Explanation and Examples, both documented
BACKUP_FILES Explanation and Examples, both documented
MYDATA_xxxx Explanation and Examples, both documented

However, there is an error in this example provided in the configfile command. According to the documentation, it should not include the leading forward slash.

EXCLUDE_/var/="/my\\ directory\\ with\\ spaces/"

should be

EXCLUDE_/var/="my\\ directory\\ with\\ spaces/"

[cleverwise]

Good catch and a typo. Fixed in 2.3.2.

[cspaniard]

The initial tests showed that the command cya directories does handle the names with spaces correctly if \\ are provided before the spaces. So far, so good.

However, when I tried to run the backup with a cya save command, I got the following errors on directories with spaces. Of course the \\ are there, otherwise cya directories would not work either.

Backing up /home/dsanroma/directory with spaces/ ... rsync: link_stat "/home/dsanroma/directory" failed: No such file or directory (2)
rsync: link_stat "/home/dsanroma/with" failed: No such file or directory (2)
rsync: change_dir "/home/cya/points/2/home/dsanroma" failed: No such file or directory (2)
rsync: link_stat "/home/dsanroma/with" failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1183) [sender=3.1.1]
 complete
Backing up /initrd.img ...  complete
Backing up /initrd.img.old ...  complete
Backing up /vmlinuz ...  complete
Backing up /vmlinuz.old ...  complete
Backing up /etc/hosts ...  complete
Backing up /etc/bash_completion.d/git-prompt ...  complete
Backing up /home/dsanroma/file with spaces ... rsync: link_stat "/home/dsanroma/file" failed: No such file or directory (2)
rsync: link_stat "/home/dsanroma/with" failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1183) [sender=3.1.1]
 complete