diff --git a/molt_setup/main.py b/molt_setup/main.py index b5cee78..c167863 100644 --- a/molt_setup/main.py +++ b/molt_setup/main.py @@ -144,7 +144,26 @@ def _extract(self, target_dir): base_name = self.sdist_base_name() with tarfile.open(unextracted_path) as tar: - tar.extractall(target_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, target_dir) return os.path.join(target_dir, base_name)