mastersthesis / phdthesis vs thesis

[michalc]

I see in the code "mastersthesis" and "phdthesis" types are used:

ruby-cff/lib/cff/formatters/apalike.rb

Lines 67 to 70 in 8f4e37e

	when 'phdthesis'
	type_and_school_from_model(model, 'Doctoral dissertation')
	when 'mastersthesis'
	type_and_school_from_model(model, "Master's thesis")

But in 1.2.0 spec it looks like the only type is "thesis" and no "mastersthesis" or "phdthesis", and similarly in the 1.3.0 spec.

I also see that in one of the tests in this repo uses mastersthesis, even though it doesn't seem to adhere to the spec.

ruby-cff/test/files/formatter/preferred-citation-masters-thesis.cff

Line 21 in 8f4e37e

type: mastersthesis

And from some of my own brief tests, I couldn't get a CITATION.cff file to validate with cffconvert if it used the type "mastersthesis".

Should the types of "mastersthesis" and "phdthesis" be replaced by a single thesis, to bring this in line with the spec?

[hainesr]

Hmm, yes I think you're right. I'll look into this.

Unfortunately, from a quick look at the APA and BibTeX formatters just now, those two citation styles do make a distinction between Masters and PhD theses, so we'll need to check (and hope) that thesis-type is used in a way that helps us...