From 88e8579baea675ea8e8d2cff0b4734536fe4bc2c Mon Sep 17 00:00:00 2001 From: colemanw Date: Fri, 19 Sep 2025 14:22:14 -0400 Subject: [PATCH] Ensure html attributes are escaped in templates This adds escape='htmlattribute' to all translations within tags, which ensures any special characters in the translated string are properly escaped and don't break out of the quotes or cause other problems. See https://github.com/civicrm/civicrm-core/pull/26792 Note: This requires CiviCRM 5.65 at minimum. --- info.xml | 11 ++++------- .../CRM/Contribute/Form/ContributionView.old.tpl | 2 +- .../CRM/Contribute/Form/ContributionView.tpl | 4 ++-- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/info.xml b/info.xml index d92d22d..1299c2b 100644 --- a/info.xml +++ b/info.xml @@ -1,5 +1,5 @@ - - + + http://extensions.circle-interactive.co.uk/uk.co.circleinteractive.offlinerecurring-v1.6.zip offlinerecurring Offline Recurring Payment @@ -19,10 +19,7 @@ 1.6 stable - 4.1 - 4.2 - 4.3 - 4.4 + 5.65 For support, please contact project team on the forums. (http://forum.civicrm.org) - + diff --git a/legacy/templates/CRM/Contribute/Form/ContributionView.old.tpl b/legacy/templates/CRM/Contribute/Form/ContributionView.old.tpl index cb98696..0aef6dc 100644 --- a/legacy/templates/CRM/Contribute/Form/ContributionView.old.tpl +++ b/legacy/templates/CRM/Contribute/Form/ContributionView.old.tpl @@ -196,7 +196,7 @@ {if $softCreditToName} {ts}Soft Credit To{/ts} - {$softCreditToName} + {$softCreditToName} {/if} diff --git a/legacy/templates/CRM/Contribute/Form/ContributionView.tpl b/legacy/templates/CRM/Contribute/Form/ContributionView.tpl index 23812ef..e927608 100644 --- a/legacy/templates/CRM/Contribute/Form/ContributionView.tpl +++ b/legacy/templates/CRM/Contribute/Form/ContributionView.tpl @@ -214,7 +214,7 @@ {if $softCreditToName and !$pcp_id} {* We show soft credit name with PCP section if contribution is linked to a PCP. *} {ts}Soft Credit To{/ts} - {$softCreditToName} + {$softCreditToName} {/if} @@ -251,7 +251,7 @@ {ts}Soft Credit To{/ts} - {$softCreditToName} + {$softCreditToName} {ts}In Public Honor Roll?{/ts}{if $pcp_display_in_roll}{ts}Yes{/ts}{else}{ts}No{/ts}{/if} {if $pcp_roll_nickname}