Skip to content

Commit 3debfb8

Browse files
committed
fix: Adjust email text to replace heading, add % to percentages
[#OCD-4757]
1 parent 1ebfcf2 commit 3debfb8

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

chpl/chpl-resources/src/main/resources/email.properties

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,12 +296,12 @@ rwt.report.body=Report contains data for the following ONC-ACBs
296296

297297
# Real World Testing Validation Email properties
298298
rwtResults.validation.subject=RWT Results Report Validation
299-
rwtResults.validation.body=<h2>RWT Results Report Validation</h2>\
300-
<h3>Validation Inputs</h3><ul><li>URL: %s</li><li>Listing: %s</li><li>Year: %s</li></ul>\
299+
rwtResults.validation.body=<h3>Validation Inputs</h3><ul>\
300+
<li>URL: %s</li><li>Listing: %s</li><li>Year: %s</li></ul>\
301301
<p>%s</p>
302302
rwtResults.validation.failure.subject=RWT Results Report Validation Failed
303-
rwtResults.validation.failure.body=<h2>RWT Results Report Validation Failed</h2>\
304-
<h3>Validation Inputs</h3><ul><li>URL: %s</li><li>Listing: %s</li><li>Year: %s</li></ul>\
303+
rwtResults.validation.failure.body=<h3>Validation Inputs</h3><ul>\
304+
<li>URL: %s</li><li>Listing: %s</li><li>Year: %s</li></ul>\
305305
<p>Reason: %s</p>
306306

307307
# Scheduled Job Change

chpl/chpl-service/src/main/java/gov/healthit/chpl/scheduler/job/realworldtesting/RealWorldTestingUrlValidationJob.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ private void sendResultsEmail(String recipientEmail, UrlValidationResponse resul
209209
.recipient(recipientEmail)
210210
.subject(emailSubject)
211211
.htmlMessage(chplHtmlEmailBuilder.initialize()
212+
.heading(emailSubject)
212213
.paragraph("", String.format(emailBody, url, getChplProductNumber(), year + "", resultsHtml))
213214
.paragraph("", String.format(chplEmailValediction, acbatlFeedbackUrl))
214215
.footer(AdminFooter.class)
@@ -230,14 +231,14 @@ private String createResultsHtml(UrlValidationResponse results) {
230231
buf.append("<li>Document URL: " + results.getDocument().getUrl() + "</li>");
231232
}
232233
if (!StringUtils.isEmpty(results.getDocument().getConfidence())) {
233-
buf.append("<li>Confidence: " + results.getDocument().getConfidence() + "</li>");
234+
buf.append("<li>Confidence: " + results.getDocument().getConfidence() + "%</li>");
234235
}
235236
buf.append("</ul>");
236237
}
237238
if (results.getValidation() != null) {
238239
buf.append("<h3>Validation Results</h3><ul>");
239240
if (!StringUtils.isEmpty(results.getValidation().getCompletenessScore())) {
240-
buf.append("<li>Completeness Score: " + results.getValidation().getCompletenessScore() + "</li>");
241+
buf.append("<li>Completeness Score: " + results.getValidation().getCompletenessScore() + "%</li>");
241242
}
242243
if (!StringUtils.isEmpty(results.getValidation().getSummary())) {
243244
buf.append("<li>Validation Summary: " + results.getValidation().getSummary() + "</li>");
@@ -261,6 +262,7 @@ private void sendErrorEmail(String recipientEmail, String errorMessage) {
261262
.recipient(recipientEmail)
262263
.subject(failureEmailSubject)
263264
.htmlMessage(chplHtmlEmailBuilder.initialize()
265+
.heading(failureEmailSubject)
264266
.paragraph("", String.format(failureEmailBody, url, listingId + "", year + "", errorMessage))
265267
.paragraph("", String.format(chplEmailValediction, acbatlFeedbackUrl))
266268
.footer(AdminFooter.class)

0 commit comments

Comments
 (0)