Skip to content

Commit ebdcb36

Browse files
committed
Remove support for environment variables in build
Use CMake options exclusively for controlling the build.
1 parent 5136f48 commit ebdcb36

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

CMakeLists.txt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ endforeach()
4141
# succession would be treated as the same build (the cache value doesn't change) and
4242
# would not lead to calling cython at all. For other options such as --profile,
4343
# again they will only be turned on or off if the command line arguments are changed.
44-
#
45-
# TODO: decide whether CMake defines or environment variables are the better approach
46-
# for dynamic configuration.
4744

4845
option(profile "Enable profiling in Cython modules." OFF)
4946
if(profile)
@@ -57,13 +54,6 @@ if(line-profile)
5754
add_compile_definitions(CYTHON_TRACE_NOGIL=1)
5855
endif()
5956

60-
# An example of using an environment variable instead of a CMake option.
61-
# Leave this undocumented for now: do we really want to include support for
62-
# annotations? Probably fine to just use `cython --annotate` on individual files.
63-
if(DEFINED ENV{CYTHON_ANNOTATE})
64-
list(APPEND CYTHON_ARGS --annotate)
65-
endif()
66-
6757
# Cython extensions are all stored in cherab/solps and subdirectories. Note: all
6858
# modifications to CYTHON_ARGS should be done before the call to add_subdirectory to
6959
# ensure subdirectories pick up the final list of arguments.

0 commit comments

Comments
 (0)