checkNameSet,
}
private static String getCheckName(TreeWalkerAuditEvent event) {
- final String[] checkNames = event.getViolation().getSourceName().split("\\.");
+ final String[] checkNames = event.violation().getSourceName().split("\\.");
return checkNames[checkNames.length - 1];
}
@@ -352,7 +352,7 @@ private static String getCheckShortName(TreeWalkerAuditEvent event) {
* @return DetailAST event's corresponding ast node
*/
private static DetailAST getEventAst(TreeWalkerAuditEvent event) {
- DetailAST curNode = event.getRootAst();
+ DetailAST curNode = event.rootAst();
DetailAST eventAst = null;
while (curNode != null) {
if (isMatchingAst(curNode, event)) {
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionJavaPatchFilterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionJavaPatchFilterTest.java
index 8df78a8b..db317275 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionJavaPatchFilterTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionJavaPatchFilterTest.java
@@ -34,7 +34,7 @@ protected String getPatchFileLocation() {
}
@Override
- protected String getPackageLocation() {
+ public String getPackageLocation() {
return "com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/";
}
@@ -55,15 +55,12 @@ public void testShortName() throws Exception {
public void testNonExistentPatchFileWithFalseOptional() throws Exception {
try {
testByConfig("Optional/false/defaultContextConfig.xml");
- }
- catch (CheckstyleException ex) {
- assertEquals("cannot initialize module TreeWalker - "
- + "cannot initialize module "
- + "com.puppycrawl.tools.checkstyle.filters.SuppressionJavaPatchFilter "
- + "- an error occurred when loading patch file "
- + getPatchFileLocation() + "Optional/false//defaultContext.patch",
- ex.getMessage(),
- "Invalid error message");
+ } catch (CheckstyleException ex) {
+ assertEquals(
+ "cannot initialize module TreeWalker - cannot initialize module "
+ + "com.puppycrawl.tools.checkstyle.filters.SuppressionJavaPatchFilter",
+ ex.getMessage()
+ );
}
}
@@ -79,7 +76,7 @@ public void testNeverSuppressedChecks() throws Exception {
testByConfig("neversuppressedchecks/CovariantEquals/"
+ "checkID/newline/defaultContextConfig.xml");
testByConfig("neversuppressedchecks/CovariantEquals"
- + "/checkID/patchedline/defaultContextConfig.xml");
+ + "/checkID/patchedline/defaultContextConfig.xml");
testByConfig("neversuppressedchecks/CovariantEquals/"
+ "checkShortName/context/defaultContextConfig.xml");
testByConfig("neversuppressedchecks/CovariantEquals/"
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java
index 7dc1fa03..69983491 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionPatchFilterTest.java
@@ -30,7 +30,7 @@ protected String getPatchFileLocation() {
}
@Override
- protected String getPackageLocation() {
+ public String getPackageLocation() {
return "com/puppycrawl/tools/checkstyle/filters/suppressionpatchfilter/";
}
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/jgit/GitDiffOnOpenSourceTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/jgit/GitDiffOnOpenSourceTest.java
index ee3190cb..f3f6a9f7 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/jgit/GitDiffOnOpenSourceTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/jgit/GitDiffOnOpenSourceTest.java
@@ -36,7 +36,7 @@
public class GitDiffOnOpenSourceTest extends AbstractModuleTestSupport {
@Override
- protected String getPackageLocation() {
+ public String getPackageLocation() {
return "com/puppycrawl/tools/checkstyle/filters/";
}
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/Regexp/context/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/Regexp/context/expected.txt
index de031c81..a7762e8d 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/Regexp/context/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/Regexp/context/expected.txt
@@ -1 +1 @@
-Test.java:0: Required pattern '// This code is copyrighted\n// \(c\) MyCompany' missing in file.
\ No newline at end of file
+Test.java:1: Required pattern '// This code is copyrighted\n// \(c\) MyCompany' missing in file.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/context/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/context/expected.txt
index 4ba166b3..6523de9f 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/context/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/context/expected.txt
@@ -1 +1 @@
-Test.java:7:5: All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '5'.
\ No newline at end of file
+Test.java:7:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '5'.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/newline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/newline/expected.txt
index 2b648be0..d0f3e917 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/newline/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/newline/expected.txt
@@ -1 +1 @@
-Test.java:15:5: All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '13'.
\ No newline at end of file
+Test.java:15:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '13'.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/patchedline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/patchedline/expected.txt
index 2b648be0..d0f3e917 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/patchedline/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/coding/OverloadMethodsDeclarationOrder/patchedline/expected.txt
@@ -1 +1 @@
-Test.java:15:5: All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '13'.
\ No newline at end of file
+Test.java:15:5: All overloaded methods should be placed next to each other. Previous overloaded method located at line '13'.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/context/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/context/expected.txt
index e418bb8b..70dbcac1 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/context/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/context/expected.txt
@@ -1 +1 @@
-Test.java:7: tag should be preceded with an empty line.
\ No newline at end of file
+Test.java:7:4:
tag should be preceded with an empty line.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/newline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/newline/expected.txt
index 5bebc583..9a4b45f5 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/newline/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/newline/expected.txt
@@ -1 +1 @@
-Test.java:8:
tag should be preceded with an empty line.
\ No newline at end of file
+Test.java:8:4:
tag should be preceded with an empty line.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/patchedline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/patchedline/expected.txt
index 5bebc583..9a4b45f5 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/patchedline/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/JavadocParagraph/patchedline/expected.txt
@@ -1 +1 @@
-Test.java:8:
tag should be preceded with an empty line.
\ No newline at end of file
+Test.java:8:4:
tag should be preceded with an empty line.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/context/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/context/expected.txt
index 8b972476..383ddc18 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/context/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/context/expected.txt
@@ -1 +1 @@
-Test.java:4: Summary javadoc is missing.
\ No newline at end of file
+Test.java:4:8: Summary javadoc is missing.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/newline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/newline/expected.txt
index 532db954..dec63543 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/newline/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/newline/expected.txt
@@ -1 +1 @@
-Test.java:9: Summary javadoc is missing.
\ No newline at end of file
+Test.java:9:8: Summary javadoc is missing.
\ No newline at end of file
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/patchedline/expected.txt b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/patchedline/expected.txt
index 8b972476..383ddc18 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/patchedline/expected.txt
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/filters/suppressionjavapatchfilter/javadoc/SummaryJavadocCheck/patchedline/expected.txt
@@ -1 +1 @@
-Test.java:4: Summary javadoc is missing.
\ No newline at end of file
+Test.java:4:8: Summary javadoc is missing.
\ No newline at end of file