From 135b15a603bea65b439b81c32fc6d08dc9f94965 Mon Sep 17 00:00:00 2001
From: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Date: Tue, 23 Dec 2025 08:11:51 +0530
Subject: [PATCH] chore: remove allow-dangling from symlink-check pipelines

there are other ways to verify the symlink like stat or readlink.
the flag `--allow-absolute` is still there but I'm inclined towards
not exposing it at pipelines level.

If we use this at inside package config then the whole point of having
a symlink-check is broken. We want to validate the integrity of fs
by making sure there's no broken symlink.

By exposing this, we're entering a greyish area where we're allowing
this and bots are learning the same.
Not exposing seems like a better default than what we had previously.
Happy to discuss other thoughts here as well.

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
---
 pipelines/test/tw/symlink-check.yaml | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/pipelines/test/tw/symlink-check.yaml b/pipelines/test/tw/symlink-check.yaml
index d96bb72..de85673 100644
--- a/pipelines/test/tw/symlink-check.yaml
+++ b/pipelines/test/tw/symlink-check.yaml
@@ -18,13 +18,6 @@ inputs:
       Use "none" to disable the default package check.
     required: false
     default: "${{context.name}}"
-  allow-dangling:
-    description: |
-      Allow dangling (broken) symlinks that point to non-existent targets.
-      Set to "true" if the package intentionally includes symlinks to files provided by other packages.
-      Default is false (dangling symlinks cause test failure).
-    default: false
-    required: false
   allow-absolute:
     description: |
       Allow absolute symlinks (e.g., /usr/bin/foo -> /usr/lib/bar).
@@ -38,11 +31,6 @@ inputs:
 # Basic check (all symlinks in current package):
 #   - uses: test/tw/symlink-check
 #
-# Allow dangling symlinks (for cross-package references):
-#   - uses: test/tw/symlink-check
-#     with:
-#       allow-dangling: true
-#
 # Allow absolute symlinks:
 #   - uses: test/tw/symlink-check
 #     with:
@@ -53,5 +41,4 @@ pipeline:
     runs: |
       symlink-check \
           --allow-absolute="${{inputs.allow-absolute}}" \
-          --allow-dangling="${{inputs.allow-dangling}}" \
           --packages="${{inputs.packages}}"