improvement and flaked . Now work from this point. modified exportcpacs ( rember to check how VSP2CPACS is working with these modifications)

Author: Nico-pera

src/app/01_✈️_Geometry.py

@@ -41,7 +41,7 @@
     render_openvsp_panel,
     convert_vsp3_to_cpacs,
 )
-from ceasiompy.stl2cpacs.func.split_stl_into_components import split_main, split_stl_by_symmetry_plane
+from ceasiompy.stl2cpacs.func.split_stl_into_components import split_main
 from ceasiompy.stl2cpacs.stl2cpacs import main as stl2cpacs_main
 from ceasiompy.stl2cpacs.stl2cpacs import cpacs_component_detection
 
@@ -73,9 +73,11 @@
 
 
 # Methods
-def _show_stl_mesh(stl_path: str, key: str,show_wireframe: bool | None = None) -> None:
+def _show_stl_mesh(stl_path: str,
+                   key: str,
+                   show_wireframe: bool | None = None
+                   ) -> None:
     """Interactive STL viewer with proper wireframe toggle refresh."""
-    
 
     # --- Cache STL loading only ---
     @st.cache_data(show_spinner=False)
@@ -84,7 +86,6 @@ def load_stl(path):
 
     stl_mesh = load_stl(stl_path)
 
-
     # Build unique vertices + face indices
     vertices = stl_mesh.vectors.reshape(-1, 3)
     verts_unique, index = np.unique(vertices, axis=0, return_inverse=True)
@@ -142,10 +143,12 @@ def load_stl(path):
     dynamic_key = f"{key}_{show_wireframe}"
 
     st.plotly_chart(fig, use_container_width=True, key=dynamic_key)
-    
+
 
 def _show_split_components_mesh(
-    split_dir: str | Path, key: str, show_wireframe: bool | None = None
+    split_dir: str | Path,
+    key: str,
+    show_wireframe: bool | None = None
 ) -> None:
     """Display split STL components with one color per component."""
 
@@ -227,8 +230,8 @@ def generate_distinct_colors(n: int) -> list[str]:
     )
     dynamic_key = f"{key}_{show_wireframe}_{len(component_files)}"
     st.plotly_chart(fig, use_container_width=True, key=dynamic_key)
-    
-    
+
+
 def _clean_toolspecific(cpacs: CPACS) -> CPACS:
     air_name = cpacs.ac_name
 
@@ -566,6 +569,7 @@ def _section_load_cpacs() -> CPACS | None:
 
 
 def _section_stl_to_cpacs():
+
     # 1. Load the stl
     st.markdown("#### Load an STL file or multiple file")
     st.markdown("You can upload a 3D STL model (binary or ASCII) to convert it to CPACS later.")
@@ -631,10 +635,10 @@ def _section_stl_to_cpacs():
         st.session_state.pop("last_split_components_dir", None)
         st.session_state["show_split_tools"] = False
         st.session_state["show_cpacs_conversion_tools"] = False
-    
+
     # 2. visualization
     wireframe_view = st.toggle("Wireframe view", value=False, key="stl_wireframe_view")
-    
+
     # 3. split tools (hidden by default)
     if "show_split_tools" not in st.session_state:
         st.session_state["show_split_tools"] = False
@@ -671,7 +675,7 @@ def _section_stl_to_cpacs():
             except Exception as exc:
                 st.error(f"STL split failed: {exc}")
 
-        
+
     # 4. Convert to CPACS using automatic component detection
     st.markdown("#### Convert to CPACS")
 
@@ -685,7 +689,6 @@ def _section_stl_to_cpacs():
         st.warning("No STL sources found in the working directory.")
         return None
 
-
     current_candidates = [str(path) for path in candidate_paths]
     selected_stl_files = current_candidates
     try:
@@ -769,7 +772,8 @@ def _section_stl_to_cpacs():
                             min_value=0.0,
                             max_value=0.5,
                             format="%.4f",
-                            help="Trailing-edge trim ratio applied on each extracted airfoil. Increase if there are oscillations on the CPACS in the TE region.",
+                            help=("Trailing-edge trim ratio applied on each extracted airfoil.",
+                                  " Increase if there are oscillations on the CPACS in the TE region."),
                             key=f"stl_component_adv_te_cut_{idx}",
                         )
                     )
@@ -779,7 +783,9 @@ def _section_stl_to_cpacs():
                             value=10,
                             min_value=3,
                             step=1,
-                            help="Bins used to split the section cloud into upper/lower surfaces. Increase if you have a very refined profile with sharp features, or if you have oscillations on the CPACS airfoil.",
+                            help=("Bins used to split the section cloud into upper/lower surfaces.",
+                                  " Increase if you have a very refined profile with sharp features,",
+                                  " or if you have oscillations on the CPACS airfoil."),
                             key=f"stl_component_adv_n_bin_{idx}",
                         )
                     )
@@ -860,7 +866,6 @@ def _section_stl_to_cpacs():
 
     return st.session_state.get("cpacs")
 
-
 # Functions
 
 def section_select_cpacs() -> None:

src/ceasiompy/stl2cpacs/func/split_stl_into_components.py

@@ -7,38 +7,23 @@
 """
 
 from __future__ import annotations
-
 from dataclasses import dataclass
 from pathlib import Path
 import struct
 from typing import Dict, List, Tuple
-
 import numpy as np
 
-
 # Quantization tolerance used to merge numerically close vertices.
 VERTEX_MERGE_TOL = 1e-6
 
-# ======================================================================================
-# VS CODE QUICK-RUN SETTINGS
-# ======================================================================================
-# Set your STL path here, then run this file directly in VS Code.
-INPUT_STL_PATH = "src/ceasiompy/STL2CPACS/SOARminSting-Shell.stl"
-
-# Set output directory for split parts. One STL per detected component.
-OUTPUT_SPLIT_DIR = "src/ceasiompy/STL2CPACS/split_output"
-
 # Connectivity tolerance used while grouping triangles into disconnected parts.
 DEFAULT_VERTEX_TOL = VERTEX_MERGE_TOL
 DEFAULT_FEATURE_ANGLE_DEG = 55.0
 SIGNIFICANT_COMPONENT_MIN_TRIS = 100
 
 # ======================================================================================
-# HOW THE SPLIT WORKS (high-level)
+# HOW THE SPLIT WORKS
 # ======================================================================================
-# The splitter does NOT try to understand aircraft semantics (wing/fuselage/etc.).
-# It only uses mesh connectivity.
-#
 # 1) Read STL triangles as an array with shape (N, 3, 3)
 #    N triangles, each triangle has 3 vertices, each vertex has (x, y, z).
 #
@@ -56,7 +41,6 @@
 # - A fully connected STL => one component file.
 # - A multi-part STL => one file per disconnected part.
 
-
 @dataclass
 class ComponentInfo:
     """Container for one split component."""
@@ -79,8 +63,6 @@ def read_ascii_stl(path: str | Path) -> np.ndarray:
                 _, x, y, z = line.split()[:4]
                 tri.append([float(x), float(y), float(z)])
 
-    if len(tri) % 3 != 0:
-        raise ValueError(f"Malformed ASCII STL: {path}")
 
     return np.asarray(tri, dtype=float).reshape(-1, 3, 3)
 
@@ -96,14 +78,14 @@ def read_binary_stl(path: str | Path) -> np.ndarray:
     tri = []
     offset = 0
     for _ in range(ntri):
-        offset += 12  # normal
+        offset += 12
         v1 = struct.unpack_from("<fff", data, offset)
         offset += 12
         v2 = struct.unpack_from("<fff", data, offset)
         offset += 12
         v3 = struct.unpack_from("<fff", data, offset)
         offset += 12
-        offset += 2  # attribute byte count
+        offset += 2
         tri.append([v1, v2, v3])
 
     return np.asarray(tri, dtype=float)
@@ -125,7 +107,10 @@ def load_stl_auto(path: str | Path) -> np.ndarray:
     return read_binary_stl(path)
 
 
-def write_binary_stl(path: str | Path, triangles: np.ndarray, solid_name: str = "component") -> None:
+def write_binary_stl(path: str | Path,
+                     triangles: np.ndarray,
+                     solid_name: str = "component"
+                     ) -> None:
     """Write triangles to a binary STL file."""
 
     tris = np.asarray(triangles, dtype=np.float32).reshape(-1, 3, 3)
@@ -171,7 +156,9 @@ def _triangle_adjacency_from_shared_vertices(triangles: np.ndarray, tol: float =
     return [list(nei) for nei in adjacency]
 
 
-def _triangle_adjacency_from_shared_edges(triangles: np.ndarray, tol: float = VERTEX_MERGE_TOL) -> List[List[int]]:
+def _triangle_adjacency_from_shared_edges(triangles: np.ndarray,
+                                          tol: float = VERTEX_MERGE_TOL
+                                          ) -> List[List[int]]:
     """Build triangle adjacency from shared *manifold* edges.
 
     Used as a fallback when vertex-connectivity yields a single component.
@@ -252,7 +239,9 @@ def _triangle_normals(triangles: np.ndarray) -> np.ndarray:
 
 
 def _triangle_adjacency_from_smooth_shared_edges(
-    triangles: np.ndarray, tol: float = VERTEX_MERGE_TOL, max_dihedral_deg: float = DEFAULT_FEATURE_ANGLE_DEG
+    triangles: np.ndarray,
+    tol: float = VERTEX_MERGE_TOL,
+    max_dihedral_deg: float = DEFAULT_FEATURE_ANGLE_DEG
 ) -> List[List[int]]:
     """Build adjacency using only manifold edges with smooth dihedral angle."""
 
@@ -336,7 +325,9 @@ def _extract_components_from_adjacency(adjacency: List[List[int]]) -> List[np.nd
     return components
 
 
-def _connected_triangle_components(triangles: np.ndarray, tol: float = VERTEX_MERGE_TOL) -> List[np.ndarray]:
+def _connected_triangle_components(triangles: np.ndarray,
+                                   tol: float = VERTEX_MERGE_TOL
+                                   ) -> List[np.ndarray]:
     """Split triangles into components with robust auto-connectivity.
 
     We treat triangles as nodes of a graph:
@@ -359,7 +350,9 @@ def _connected_triangle_components(triangles: np.ndarray, tol: float = VERTEX_ME
     return _extract_components_from_adjacency(edge_adj)
 
 
-def _count_significant_components(components: List[np.ndarray], min_triangles: int = SIGNIFICANT_COMPONENT_MIN_TRIS) -> int:
+def _count_significant_components(components: List[np.ndarray],
+                                  min_triangles: int = SIGNIFICANT_COMPONENT_MIN_TRIS
+                                  ) -> int:
     """Count components with enough triangles to be meaningful geometric parts."""
 
     return int(sum(1 for c in components if len(c) >= min_triangles))
@@ -434,7 +427,9 @@ def _histogram_valley_threshold(values: np.ndarray, n_bins: int = 80) -> float |
     return float(0.5 * (edges[best_i] + edges[best_i + 1]))
 
 
-def _induced_components_from_mask(adjacency: List[List[int]], mask: np.ndarray) -> List[np.ndarray]:
+def _induced_components_from_mask(adjacency: List[List[int]],
+                                  mask: np.ndarray
+                                  ) -> List[np.ndarray]:
     """Connected components of the subgraph induced by `mask`."""
 
     mask = np.asarray(mask, dtype=bool)
@@ -458,7 +453,9 @@ def _induced_components_from_mask(adjacency: List[List[int]], mask: np.ndarray)
 
 
 def _span_split_largest_component(
-    triangles: np.ndarray, comp_indices: List[np.ndarray], tol: float = VERTEX_MERGE_TOL
+    triangles: np.ndarray,
+    comp_indices: List[np.ndarray],
+    tol: float = VERTEX_MERGE_TOL
 ) -> List[np.ndarray]:
     """Split one dominant shell into inboard/outboard parts using |y| valley."""
 
@@ -498,7 +495,9 @@ def _span_split_largest_component(
     return remapped
 
 
-def _build_generic_components(disconnected_components: List[np.ndarray], triangles: np.ndarray) -> List[ComponentInfo]:
+def _build_generic_components(disconnected_components: List[np.ndarray],
+                              triangles: np.ndarray
+                              ) -> List[ComponentInfo]:
     """Build generic component objects from connected triangle groups.
 
     This function only packages metadata and names:
@@ -667,7 +666,6 @@ def split_aircraft_stl(
     return components
 
 
-
 def split_main(stl_path: str | Path, namefile: str, out_dir: str | Path) -> Path:
 
     vertex_tol = DEFAULT_VERTEX_TOL
@@ -683,11 +681,10 @@ def split_main(stl_path: str | Path, namefile: str, out_dir: str | Path) -> Path
     split_dir = Path(out_dir) / "STL2CPACS"
     print(f"Output dir: {split_dir}")
 
-    comps = split_aircraft_stl(stl_path, output_dir=out_dir, vertex_tol=vertex_tol,name=namefile)
+    comps = split_aircraft_stl(stl_path, output_dir=out_dir, vertex_tol=vertex_tol, name=namefile)
     if not comps:
         print("No triangles found.")
     else:
         print(f"\nWrote {len(comps)} split STL file(s) into: {split_dir}")
 
     return split_dir
-