Skip to content

Commit 46e4d5d

Browse files
Fixing EC2 + MySQL example (#63)
* Fixing EC2 + MySQL example * Fixing Postgres module * Fix * Final fix * Fixing RDS Postgres test * Fix
1 parent 6cb3c28 commit 46e4d5d

5 files changed

Lines changed: 23 additions & 9 deletions

File tree

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
with:
1919
role-to-assume: 'arn:aws:iam::068189904525:role/github-openid-connect'
2020
aws-region: 'eu-west-1'
21+
role-duration-seconds: 7200
2122
- uses: actions/setup-node@v4
2223
with:
2324
node-version: '18.x'

examples/ec2-mysql/example.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ Resources:
4545
VpcModule: !GetAtt 'Vpc.Outputs.StackName'
4646
ClientSgModule: !GetAtt 'ClientSg.Outputs.StackName'
4747
AlertingModule: !GetAtt 'Alerting.Outputs.StackName'
48+
EngineVersion: '8.4.3'
4849
DBMasterUserPassword: insecure
4950
DBBackupRetentionPeriod: '0' # speed up the example (do not set to 0 in production!)
5051
DBMultiAZ: 'false' # speed up the example (do not set to false in production!)

examples/ec2-postgres/example.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Resources:
4949
DBMasterUserPassword: insecure
5050
DBBackupRetentionPeriod: '0' # speed up the example (do not set to 0 in production!)
5151
DBMultiAZ: 'false' # speed up the example (do not set to false in production!)
52-
EngineVersion: '14.2'
52+
EngineVersion: '17.2'
5353
TemplateURL: './node_modules/@cfn-modules/rds-postgres/module.yml'
5454
Instance:
5555
Type: 'AWS::CloudFormation::Stack'

examples/ec2-postgres/package-lock.json

Lines changed: 19 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ec2-postgres/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"dependencies": {
99
"@cfn-modules/alerting": "1.2.2",
1010
"@cfn-modules/vpc": "2.3.0",
11-
"@cfn-modules/rds-postgres": "2.3.1",
11+
"@cfn-modules/rds-postgres": "2.4.6",
1212
"@cfn-modules/client-sg": "1.0.0",
1313
"@cfn-modules/ec2-instance-amazon-linux": "2.4.0"
1414
}

0 commit comments

Comments
 (0)