Add comment about how to fix IterSwap and InsertionSort for SoA tracks

OliverRietmann · OliverRietmann · commit 3f1cc807daed · 2026-04-13T16:11:21.000+02:00
diff --git a/GPU/Common/GPUCommonAlgorithm.h b/GPU/Common/GPUCommonAlgorithm.h
@@ -79,7 +79,7 @@ class GPUCommonAlgorithm
 template <typename I>
 GPUdi() void GPUCommonAlgorithm::IterSwap(I a, I b) noexcept
 {
-  auto tmp = *a;
+  auto tmp = *a; // TODO: Fails with SoA tracks (segfault)! Fix by replacing auto by typename std::iterator_traits<I>::value_type
   *a = *b;
   *b = tmp;
 }
@@ -89,7 +89,7 @@ GPUdi() void GPUCommonAlgorithm::InsertionSort(I f, I l, Cmp cmp) noexcept
 {
   auto it0{f};
   while (it0 != l) {
-    auto tmp{*it0};
+    auto tmp{*it0}; // TODO: Fails with SoA tracks (segfault)! Fix by replacing auto by typename std::iterator_traits<I>::value_type
 
     auto it1{it0};
     while (it1 != f && cmp(tmp, it1[-1])) {

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ class GPUCommonAlgorithm`
`79`	`79`	`template <typename I>`
`80`	`80`	`GPUdi() void GPUCommonAlgorithm::IterSwap(I a, I b) noexcept`
`81`	`81`	`{`
`82`		`- auto tmp = *a;`
	`82`	`+ auto tmp = *a; // TODO: Fails with SoA tracks (segfault)! Fix by replacing auto by typename std::iterator_traits<I>::value_type`
`83`	`83`	`a = b;`
`84`	`84`	`*b = tmp;`
`85`	`85`	`}`
`@@ -89,7 +89,7 @@ GPUdi() void GPUCommonAlgorithm::InsertionSort(I f, I l, Cmp cmp) noexcept`
`89`	`89`	`{`
`90`	`90`	`auto it0{f};`
`91`	`91`	`while (it0 != l) {`
`92`		`- auto tmp{*it0};`
	`92`	`+ auto tmp{*it0}; // TODO: Fails with SoA tracks (segfault)! Fix by replacing auto by typename std::iterator_traits<I>::value_type`
`93`	`93`
`94`	`94`	`auto it1{it0};`
`95`	`95`	`while (it1 != f && cmp(tmp, it1[-1])) {`