address PR comments

Author: msladek

celements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java

@@ -177,8 +177,7 @@ public int getContentSize(XWikiContext context) throws XWikiException {
     if (this.attachment_content == null) {
       this.doc.loadAttachmentContent(this, context);
     }
-
-    return (int) this.attachment_content.getSize();
+    return this.attachment_content.getSize();
   }
 
   public String getFilename() {
@@ -620,7 +619,7 @@ public void setContent(byte[] data) {
     try (InputStream is = new ByteArrayInputStream(data)) {
       setContent(is);
     } catch (IOException e) {
-      throw new RuntimeException("This should never happen", e);
+      throw new RuntimeException("Failed to set attachment content from byte array", e);
     }
   }
 

celements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java

@@ -229,14 +229,19 @@ public void setContent(InputStream is) throws IOException {
     this.newFileItem();
     IOUtils.copy(is, this.file.getOutputStream());
     this.setContentDirty(true);
-    this.attachment.setFilesize((int) this.getSize());
+    this.attachment.setFilesize(this.getSize());
   }
 
   /**
    * @return the true size of the content of the attachment.
    * @since 2.3M2
    */
-  public long getSize() {
-    return this.file.getSize();
+  public int getSize() {
+    long size = file.getSize();
+    if (size <= Integer.MAX_VALUE) {
+      return (int) size;
+    } else {
+      throw new IllegalStateException("Attachment size " + size + " exceeds max value");
+    }
   }
 }