Skip to content

Commit c5d86d9

Browse files
committed
Remove redundant base FieldMask handler now that both converters intercept it
1 parent abbd7cf commit c5d86d9

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

common/src/main/java/dev/cel/common/values/BaseProtoCelValueConverter.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
import static com.google.common.collect.ImmutableList.toImmutableList;
1818
import static com.google.common.collect.ImmutableMap.toImmutableMap;
1919

20-
import com.google.common.base.CaseFormat;
21-
import com.google.common.base.Joiner;
2220
import com.google.common.base.Preconditions;
2321
import com.google.common.collect.ImmutableList;
2422
import com.google.common.collect.ImmutableMap;
@@ -29,7 +27,6 @@
2927
import com.google.protobuf.BytesValue;
3028
import com.google.protobuf.DoubleValue;
3129
import com.google.protobuf.Duration;
32-
import com.google.protobuf.FieldMask;
3330
import com.google.protobuf.FloatValue;
3431
import com.google.protobuf.Int32Value;
3532
import com.google.protobuf.Int64Value;
@@ -44,8 +41,6 @@
4441
import dev.cel.common.annotations.Internal;
4542
import dev.cel.common.internal.ProtoTimeUtils;
4643
import dev.cel.common.internal.WellKnownProto;
47-
import java.util.ArrayList;
48-
import java.util.List;
4944

5045
/**
5146
* {@code BaseProtoCelValueConverter} contains the common logic for converting between native Java
@@ -103,15 +98,6 @@ protected Object fromWellKnownProto(MessageLiteOrBuilder message, WellKnownProto
10398
return UnsignedLong.valueOf(((UInt32Value) message).getValue());
10499
case UINT64_VALUE:
105100
return UnsignedLong.fromLongBits(((UInt64Value) message).getValue());
106-
case FIELD_MASK:
107-
FieldMask fieldMask = (FieldMask) message;
108-
List<String> paths = new ArrayList<>(fieldMask.getPathsCount());
109-
for (String path : fieldMask.getPathsList()) {
110-
if (!path.isEmpty()) {
111-
paths.add(CaseFormat.LOWER_UNDERSCORE.to(CaseFormat.LOWER_CAMEL, path));
112-
}
113-
}
114-
return normalizePrimitive(Joiner.on(",").join(paths));
115101
case EMPTY:
116102
return ImmutableMap.of();
117103
default:

0 commit comments

Comments
 (0)