Skip to content

Commit 659bfb9

Browse files
l46kokcopybara-github
authored andcommitted
Remove duplicate policy tests that's already covered by conformance tests
PiperOrigin-RevId: 924921276
1 parent 98ce0bf commit 659bfb9

2 files changed

Lines changed: 1 addition & 108 deletions

File tree

testing/src/test/java/dev/cel/testing/testrunner/BUILD.bazel

Lines changed: 0 additions & 107 deletions
Original file line numberDiff line numberDiff line change
@@ -155,33 +155,6 @@ java_test(
155155
],
156156
)
157157

158-
cel_java_test(
159-
name = "test_runner_sample_yaml",
160-
cel_expr = "@cel_policy//conformance:testdata/nested_rule/policy.yaml",
161-
proto_deps = [
162-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_proto",
163-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_proto",
164-
],
165-
test_src = ":user_test",
166-
test_suite = "@cel_policy//conformance:testdata/nested_rule/tests.yaml",
167-
deps = [
168-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
169-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
170-
],
171-
)
172-
173-
cel_java_test(
174-
name = "unknown_set_yaml",
175-
cel_expr = "@cel_policy//conformance:testdata/nested_rule/policy.yaml",
176-
proto_deps = [
177-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_proto",
178-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_proto",
179-
],
180-
test_data_path = "//testing/src/test/resources/policy",
181-
test_src = ":user_test",
182-
test_suite = "nested_rule/testrunner_unknown_output_tests.yaml",
183-
)
184-
185158
cel_java_test(
186159
name = "custom_variable_binding_test_runner_sample",
187160
cel_expr = "custom_variable_bindings/policy.yaml",
@@ -208,53 +181,6 @@ cel_java_test(
208181
test_suite = "nested_rule/eval_error_tests.yaml",
209182
)
210183

211-
cel_java_test(
212-
name = "context_pb_user_test_runner_sample",
213-
cel_expr = "@cel_policy//conformance:testdata/context_pb/policy.yaml",
214-
config = "@cel_policy//conformance:testdata/context_pb/config.yaml",
215-
proto_deps = [
216-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_proto",
217-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_proto",
218-
],
219-
test_src = ":context_pb_user_test",
220-
test_suite = "@cel_policy//conformance:testdata/context_pb/tests.yaml",
221-
deps = [
222-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
223-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
224-
],
225-
)
226-
227-
cel_java_test(
228-
name = "additional_config_test_runner_sample",
229-
cel_expr = "@cel_policy//conformance:testdata/nested_rule/policy.yaml",
230-
config = "@cel_policy//conformance:testdata/nested_rule/config.yaml",
231-
proto_deps = [
232-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_proto",
233-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_proto",
234-
],
235-
test_src = ":env_config_user_test",
236-
test_suite = "@cel_policy//conformance:testdata/nested_rule/tests.textproto",
237-
deps = [
238-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
239-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
240-
],
241-
)
242-
243-
cel_java_test(
244-
name = "test_runner_sample",
245-
cel_expr = "@cel_policy//conformance:testdata/nested_rule/policy.yaml",
246-
proto_deps = [
247-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_proto",
248-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_proto",
249-
],
250-
test_src = ":user_test",
251-
test_suite = "@cel_policy//conformance:testdata/nested_rule/tests.textproto",
252-
deps = [
253-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
254-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
255-
],
256-
)
257-
258184
cel_java_test(
259185
name = "test_runner_sample_with_expr_value_output",
260186
cel_expr = "expr_value_output/policy.yaml",
@@ -280,39 +206,6 @@ cel_java_test(
280206
],
281207
)
282208

283-
cel_java_test(
284-
name = "context_message_user_test_runner_textproto_sample",
285-
cel_expr = "@cel_policy//conformance:testdata/context_pb/policy.yaml",
286-
config = "@cel_policy//conformance:testdata/context_pb/config.yaml",
287-
proto_deps = [
288-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_proto",
289-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_proto",
290-
],
291-
test_data_path = "//testing/src/test/resources/policy",
292-
test_src = ":context_pb_user_test",
293-
test_suite = "context_pb/context_msg_tests.textproto",
294-
deps = [
295-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
296-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
297-
],
298-
)
299-
300-
cel_java_test(
301-
name = "context_pb_user_test_runner_textproto_sample",
302-
cel_expr = "@cel_policy//conformance:testdata/context_pb/policy.yaml",
303-
config = "@cel_policy//conformance:testdata/context_pb/config.yaml",
304-
proto_deps = [
305-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_proto",
306-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_proto",
307-
],
308-
test_src = ":context_pb_user_test",
309-
test_suite = "@cel_policy//conformance:testdata/context_pb/tests.textproto",
310-
deps = [
311-
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
312-
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
313-
],
314-
)
315-
316209
cel_java_test(
317210
name = "raw_expression_test",
318211
cel_expr = "2 + 2 == 4",

testing/testrunner/cel_java_test.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ load("@bazel_skylib//lib:paths.bzl", "paths")
2121
load("@com_google_protobuf//bazel:java_proto_library.bzl", "java_proto_library")
2222

2323
def _is_label(s):
24-
return s.startswith("//") or s.startswith(":") or s.startswith("@")
24+
return s.startswith("//") or s.startswith(":")
2525

2626
def cel_java_test(
2727
name,

0 commit comments

Comments
 (0)