Introduce 'list' extension functions: 'slice', "distinct', 'reverse', 'sort', 'sortBy'

Add versions to the 'lists' extension to gradually expose new functions.

PiperOrigin-RevId: 780339619

Author: dmitriplotnikov

common/src/main/java/dev/cel/common/internal/ComparisonFunctions.java

@@ -15,6 +15,7 @@
 package dev.cel.common.internal;
 
 import com.google.common.primitives.UnsignedLong;
+import com.google.common.primitives.UnsignedLongs;
 import com.google.errorprone.annotations.CheckReturnValue;
 import dev.cel.common.annotations.Internal;
 
@@ -114,5 +115,46 @@ public static boolean numericEquals(Number x, Number y) {
     return false;
   }
 
+
+  /**
+   * Compare two numeric values of any type (double, int, uint).
+   */
+  public static int numericCompare(Number x, Number y) {
+    if (x instanceof Double) {
+      if (y instanceof Double) {
+        return ((Double) x).compareTo((Double) y);
+      }
+      if (y instanceof Long) {
+        return compareDoubleInt((Double) x, (Long) y);
+      }
+      if (y instanceof UnsignedLong) {
+        return compareDoubleUint((Double) x, (UnsignedLong) y);
+      }
+    }
+    if (x instanceof Long) {
+      if (y instanceof Long) {
+        return Long.compare((Long) x, (Long) y);
+      }
+      if (y instanceof Double) {
+        return compareIntDouble((Long) x, (Double) y);
+      }
+      if (y instanceof UnsignedLong) {
+        return compareIntUint((Long) x, (UnsignedLong) y);
+      }
+    }
+    if (x instanceof UnsignedLong) {
+      if (y instanceof UnsignedLong) {
+        return UnsignedLongs.compare(x.longValue(), y.longValue());
+      }
+      if (y instanceof Double) {
+        return compareUintDouble((UnsignedLong) x, (Double) y);
+      }
+      if (y instanceof Long) {
+        return compareUintInt((UnsignedLong) x, (Long) y);
+      }
+    }
+    return 0;
+  }
+
   private ComparisonFunctions() {}
 }

common/src/test/java/dev/cel/common/internal/ComparisonFunctionsTest.java

@@ -64,4 +64,33 @@ public void compareUintIntEdgeCases() {
     assertThat(ComparisonFunctions.compareUintInt(ux, 1)).isEqualTo(1);
     assertThat(ComparisonFunctions.compareIntUint(1, ux)).isEqualTo(-1);
   }
+
+  @Test
+  @TestParameters("{x: 1, y: 1, expect: 0}")
+  @TestParameters("{x: 1, y: 2, expect: -1}")
+  @TestParameters("{x: 2, y: -1, expect: 1}")
+  public void numericCompareDoubleInt(double x, long y, int expect) {
+    assertThat(ComparisonFunctions.numericCompare(x, y)).isEqualTo(expect);
+    assertThat(ComparisonFunctions.numericCompare(y, x)).isEqualTo(-1 * expect);
+  }
+
+  @Test
+  @TestParameters("{x: 1, y: 1, expect: 0}")
+  @TestParameters("{x: 1, y: 2, expect: -1}")
+  @TestParameters("{x: 2, y: 1, expect: 1}")
+  public void numericCompareDoubleUint(double x, long y, int expect) {
+    UnsignedLong uy = UnsignedLong.valueOf(y);
+    assertThat(ComparisonFunctions.numericCompare(x, uy)).isEqualTo(expect);
+    assertThat(ComparisonFunctions.numericCompare(uy, x)).isEqualTo(-1 * expect);
+  }
+
+  @Test
+  @TestParameters("{x: 1, y: 1, expect: 0}")
+  @TestParameters("{x: 1, y: 2, expect: -1}")
+  @TestParameters("{x: 2, y: -1, expect: 1}")
+  public void numericCompareUintInt(long x, long y, int expect) {
+    UnsignedLong ux = UnsignedLong.valueOf(x);
+    assertThat(ComparisonFunctions.numericCompare(ux, y)).isEqualTo(expect);
+    assertThat(ComparisonFunctions.numericCompare(y, ux)).isEqualTo(-1 * expect);
+  }
 }

extensions/src/main/java/dev/cel/extensions/BUILD.bazel

@@ -27,6 +27,9 @@ java_library(
         ":sets_function",
         ":strings",
         "//common:options",
+        "//common/internal:env_visitor",
+        "//compiler",
+        "//compiler:compiler_builder",
         "@maven//:com_google_guava_guava",
     ],
 )
@@ -237,10 +240,17 @@ java_library(
     deps = [
         "//checker:checker_builder",
         "//common:compiler_common",
+        "//common:options",
+        "//common/ast",
+        "//common/internal:comparison_functions",
         "//common/types",
         "//compiler:compiler_builder",
+        "//parser:macro",
+        "//parser:operator",
+        "//parser:parser_builder",
         "//runtime",
         "//runtime:function_binding",
+        "//runtime:runtime_equality",
         "@maven//:com_google_guava_guava",
     ],
 )

extensions/src/main/java/dev/cel/extensions/CelExtensions.java

@@ -20,6 +20,10 @@
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Streams;
 import dev.cel.common.CelOptions;
+import dev.cel.common.internal.EnvVisitable;
+import dev.cel.compiler.CelCompiler;
+import dev.cel.compiler.CelCompilerFactory;
+import dev.cel.compiler.CelCompilerLibrary;
 import dev.cel.extensions.CelListsExtensions.Function;
 import java.util.Set;
 
@@ -35,7 +39,6 @@ public final class CelExtensions {
   private static final CelProtoExtensions PROTO_EXTENSIONS = new CelProtoExtensions();
   private static final CelBindingsExtensions BINDINGS_EXTENSIONS = new CelBindingsExtensions();
   private static final CelEncoderExtensions ENCODER_EXTENSIONS = new CelEncoderExtensions();
-  private static final CelListsExtensions LISTS_EXTENSIONS_ALL = new CelListsExtensions();
   private static final CelRegexExtensions REGEX_EXTENSIONS = new CelRegexExtensions();
 
   /**
@@ -230,7 +233,16 @@ public static CelSetsExtensions sets(CelOptions celOptions, Set<SetsFunction> fu
    * CelListsExtensions.Function}.
    */
   public static CelListsExtensions lists() {
-    return LISTS_EXTENSIONS_ALL;
+    return new CelListsExtensions(Integer.MAX_VALUE);
+  }
+
+  /**
+   * Extended functions for List manipulation.
+   *
+   * <p>Refer to README.md for functions available in each version.
+   */
+  public static CelListsExtensions lists(int version) {
+    return new CelListsExtensions(version);
   }
 
   /**
@@ -293,5 +305,16 @@ public static ImmutableSet<String> getAllFunctionNames() {
         .collect(toImmutableSet());
   }
 
+  public static ImmutableSet<String> getFunctionNames(CelCompilerLibrary library) {
+    ImmutableSet.Builder<String> builder = ImmutableSet.builder();
+    CelCompiler compiler =
+        CelCompilerFactory.standardCelCompilerBuilder()
+            .setStandardEnvironmentEnabled(false)
+            .addLibraries(library)
+            .build();
+    ((EnvVisitable) compiler).accept((name, decls) -> builder.add(name));
+    return builder.build();
+  }
+
   private CelExtensions() {}
 }