From 78b04744278c03140c0679c1497ce087113e0779 Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 15:17:15 -0400 Subject: [PATCH 1/8] name change --- .github/workflows/test-suite.yml | 3 ++- .github/workflows/upload-pr-artifact.yml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 46c8e050e..08c3da718 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -1,7 +1,7 @@ name: CORE Test Suite Validation on: workflow_run: - workflows: ["Upload PR Artifact"] + workflows: ["Upload-PR-Artifact"] types: [completed] workflow_dispatch: inputs: @@ -138,6 +138,7 @@ jobs: echo "Dask comparison completed successfully (no differences)" else echo "Dask comparison found differences" + fi - name: Generate dask comparison summary if: steps.dask_run.outputs.dask_success == 'true' diff --git a/.github/workflows/upload-pr-artifact.yml b/.github/workflows/upload-pr-artifact.yml index 69ea21610..7807fd00f 100644 --- a/.github/workflows/upload-pr-artifact.yml +++ b/.github/workflows/upload-pr-artifact.yml @@ -1,4 +1,4 @@ -name: Upload PR Artifact +name: Upload-PR-Artifact on: pull_request: branches: From 140a49f6d7546a36977416d987389d160796a636 Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 15:32:56 -0400 Subject: [PATCH 2/8] trigger --- .github/workflows/test-suite.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 08c3da718..669ef168d 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -20,7 +20,7 @@ jobs: validate: runs-on: ubuntu-latest # Only run if the workflow_run was successful or if manually triggered/pushed - if: | + if: > github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' From 93592366d1aad3b0a8b01de244b039c461734660 Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 15:44:46 -0400 Subject: [PATCH 3/8] test --- .github/workflows/open-rules-dispatch.yml | 2 ++ .github/workflows/test-suite.yml | 1 + 2 files changed, 3 insertions(+) diff --git a/.github/workflows/open-rules-dispatch.yml b/.github/workflows/open-rules-dispatch.yml index 9a6779af0..481ad3886 100644 --- a/.github/workflows/open-rules-dispatch.yml +++ b/.github/workflows/open-rules-dispatch.yml @@ -1,3 +1,5 @@ +name: Open Rules Submodule Dispatch + on: push: branches: [main] diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 669ef168d..274034760 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -3,6 +3,7 @@ on: workflow_run: workflows: ["Upload-PR-Artifact"] types: [completed] + branches: [main] workflow_dispatch: inputs: pr_number: From 10fca9ea369d3a0c643dc28bbd21c762e1214e46 Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 15:48:19 -0400 Subject: [PATCH 4/8] test --- .github/workflows/open-rules-dispatch.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/open-rules-dispatch.yml b/.github/workflows/open-rules-dispatch.yml index 481ad3886..4279f5c2c 100644 --- a/.github/workflows/open-rules-dispatch.yml +++ b/.github/workflows/open-rules-dispatch.yml @@ -13,4 +13,4 @@ jobs: - name: Dispatch to cdisc-open-rules run: gh api repos/cdisc-org/cdisc-open-rules/dispatches -f event_type=engine-updated env: - GH_TOKEN: ${{ secrets.OPEN_RULES_PAT }} \ No newline at end of file + GH_TOKEN: ${{ secrets.OPEN_RULES_PAT }} From be035d4617c3bf7940b340a33e334204d89e4a19 Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 15:56:23 -0400 Subject: [PATCH 5/8] remove branch --- .github/workflows/test-suite.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 274034760..2e4686145 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -1,9 +1,10 @@ name: CORE Test Suite Validation + on: workflow_run: workflows: ["Upload-PR-Artifact"] types: [completed] - branches: [main] + workflow_dispatch: inputs: pr_number: From 5d0cfbbcd20f9b5c87be1e969a1251a9a1bac78b Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 16:07:44 -0400 Subject: [PATCH 6/8] if trigger --- .github/workflows/test-suite.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 2e4686145..afba0c812 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -22,10 +22,7 @@ jobs: validate: runs-on: ubuntu-latest # Only run if the workflow_run was successful or if manually triggered/pushed - if: > - github.event_name == 'push' || - github.event_name == 'workflow_dispatch' || - github.event.workflow_run.conclusion == 'success' + if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_run' }} steps: - name: Download PR engine artifact if: github.event_name == 'workflow_run' From 76e54aea4084b53632cdd4c8564604b42672424f Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 16:15:58 -0400 Subject: [PATCH 7/8] test --- .github/workflows/test-suite.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index afba0c812..f8d8de961 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -4,6 +4,8 @@ on: workflow_run: workflows: ["Upload-PR-Artifact"] types: [completed] + branches: + - "**" workflow_dispatch: inputs: @@ -22,7 +24,10 @@ jobs: validate: runs-on: ubuntu-latest # Only run if the workflow_run was successful or if manually triggered/pushed - if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_run' }} + if: >- + github.event_name == 'push' || + github.event_name == 'workflow_dispatch' || + (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') steps: - name: Download PR engine artifact if: github.event_name == 'workflow_run' From 977967bab6ad28e8d7a64c68f7287efcefbfb300 Mon Sep 17 00:00:00 2001 From: Samuel Johnson Date: Wed, 22 Apr 2026 16:16:13 -0400 Subject: [PATCH 8/8] remove comment --- .github/workflows/test-suite.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index f8d8de961..ca4c39992 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -23,7 +23,6 @@ env: jobs: validate: runs-on: ubuntu-latest - # Only run if the workflow_run was successful or if manually triggered/pushed if: >- github.event_name == 'push' || github.event_name == 'workflow_dispatch' ||