Skip to content

Define xml#39

Merged
SFJohnson24 merged 3 commits into
mainfrom
define_xml
May 21, 2026
Merged

Define xml#39
SFJohnson24 merged 3 commits into
mainfrom
define_xml

Conversation

@SFJohnson24
Copy link
Copy Markdown
Collaborator

@SFJohnson24 SFJohnson24 commented May 19, 2026

  • originally had logic in this PR to create a complete path but moved the change to engine repo; this PR represents a small change to add logic to logs to the test.py runs.
  • i used CORE-000929 and the data for it has been changed to correctly run (CT and define 2.1 cannot be given as the define specifies the CT, the results are updated for what engine outputs)

@SFJohnson24 SFJohnson24 linked an issue May 20, 2026 that may be closed by this pull request
@SFJohnson24 SFJohnson24 marked this pull request as ready for review May 20, 2026 13:16
@SFJohnson24 SFJohnson24 self-assigned this May 20, 2026
Copy link
Copy Markdown

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch still points to engine @ bc6ec1d but the commit to engine that has changes to handle updated test data is d6686aa. I think we should update it. Please let me know if I am misunderstanding something here.

@SFJohnson24
Copy link
Copy Markdown
Collaborator Author

@RamilCDISC #36 just merged

Copy link
Copy Markdown

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the test data as the engine now handles the define xml paths properly. The update here is to test data. The validation script, test and readme all are updated properly. The concern for the engine version is resolved in a separate PR #36
All looks fine.

@SFJohnson24 SFJohnson24 merged commit 2935353 into main May 21, 2026
3 checks passed
@SFJohnson24 SFJohnson24 deleted the define_xml branch May 21, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

define-xml open rules

2 participants