Define xml#39
Merged
Merged
Conversation
RamilCDISC
requested changes
May 20, 2026
RamilCDISC
left a comment
There was a problem hiding this comment.
This branch still points to engine @ bc6ec1d but the commit to engine that has changes to handle updated test data is d6686aa. I think we should update it. Please let me know if I am misunderstanding something here.
Collaborator
Author
|
@RamilCDISC #36 just merged |
RamilCDISC
approved these changes
May 20, 2026
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates the test data as the engine now handles the define xml paths properly. The update here is to test data. The validation script, test and readme all are updated properly. The concern for the engine version is resolved in a separate PR #36
All looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.