changes in validation script to change engine location#22
changes in validation script to change engine location#22alexfurmenkov wants to merge 28 commits into
Conversation
| tr,TRSTAT,Completion Status,Char,50 | ||
| tr,TRREASND,Reason Not Done,Char,50 | ||
| tr,TRNAM,Laboratory/Vendor Name,Char,50 | ||
| tr,TRLOC,Location of the Tumor/Lesion,Char,50 |
There was a problem hiding this comment.
Here in the data TRLOC is added. The relevant rule in this folder checks for presence of this variable and raises error if this is present. The result.csv file is not updated which I believe would change after addition of this variable in the data.
There was a problem hiding this comment.
TRLOC should not be in the positive data-- it should only exist in the negative data as that is the failure criteria for the rule
|
|
||
| done # cases | ||
| done # test types | ||
| done < <(find "$TYPE_DIR" -mindepth 1 -maxdepth 1 -type d -print0 | sort -z) |
There was a problem hiding this comment.
This is for to handle the spaces in the path safely but the for loop in the top does not use it. For this to be affective use while loop instead of for loop.
|
@SFJohnson24 or anyone who can, can you please delete this PR and rules_2 branch fromBranches? rules_2 became protected and I can't push anymore. created new PR with the same changes and latest changes requested by @RamilCDISC |
|
@alexfurmenkov resolved the branch protections issue--I believe you shouldnt have a problem now |
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
Only this small change after which I think it would be good to merge.
| R_MATCH="$4" \ | ||
| R_DIFF="$5" \ | ||
| R_STDERR="$6" \ | ||
| python3 -c " |
There was a problem hiding this comment.
I think we should not hardcode python3 here. The script may fail on system where python is not registered as python3
3 participants
No description provided.