Disable min/max EditableNumber hotkeys

ccjmne · ccjmne · commit 88f5d391e7d8 · 2025-02-12T23:20:28.000+01:00
What should happen when you set the TimeInput to Infinity? How
discoverable is that feature anyways? How useful?
diff --git a/src/lib/EditableNumber.svelte b/src/lib/EditableNumber.svelte
@@ -31,8 +31,6 @@
   function onkeydown(e: KeyboardEvent) {
     if (['ArrowUp', 'ArrowRight'].includes(e.key)) value = Math.min(value + 1, max)
     else if (['ArrowDown', 'ArrowLeft'].includes(e.key)) value = Math.max(value - 1, min)
-    else if (['Home', 'PageUp'].includes(e.key)) value = max
-    else if (['End', 'PageDown'].includes(e.key)) value = min
     if (e.key === 'Tab' && isNaN(parseInt(e.key))) e.preventDefault()
   }
 </script>

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,6 @@`
`31`	`31`	`function onkeydown(e: KeyboardEvent) {`
`32`	`32`	`if (['ArrowUp', 'ArrowRight'].includes(e.key)) value = Math.min(value + 1, max)`
`33`	`33`	`else if (['ArrowDown', 'ArrowLeft'].includes(e.key)) value = Math.max(value - 1, min)`
`34`		`- else if (['Home', 'PageUp'].includes(e.key)) value = max`
`35`		`- else if (['End', 'PageDown'].includes(e.key)) value = min`
`36`	`34`	`if (e.key === 'Tab' && isNaN(parseInt(e.key))) e.preventDefault()`
`37`	`35`	`}`
`38`	`36`	`</script>`