Skip to content

Commit a22bee5

Browse files
authored
Verbose nested namespace syntax (not C++17) (#7)
* Verbose nested namespace syntax (not C++17) This more verbose syntax does not require C++17 syntax and works with older compilers. Resolves: #6 * update NEWS.txt with entry about namespace sytnax
1 parent 968df86 commit a22bee5

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

NEWS.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Changelog
44
- Bugfix: Fixed byte order in image format string used for Pillow
55
- Bugfix: Prevent segmentation fault when performing some operations on locked documents (fixes #4)
66
- Bugfix: Fix include paths in C++ (fixes #2)
7+
- Change namespace syntax to support old compilers (earlier than C++17) (fixes #6)
78

89
0.2.0
910
- Add the font infos to the TextBox object (Poppler 0.89.0)

src/cpp/version.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,11 @@
1919
#include <pybind11/pybind11.h>
2020
#include <poppler-version.h>
2121

22-
namespace poppler::version
22+
namespace poppler
2323
{
24+
namespace version
25+
{
26+
2427

2528
PYBIND11_MODULE(version, m)
2629
{
@@ -30,4 +33,5 @@ PYBIND11_MODULE(version, m)
3033
m.def("version_micro", &version_micro);
3134
}
3235

33-
} // namespace poppler::version
36+
} // namespace version
37+
} // namespace poppler

0 commit comments

Comments
 (0)