docs: extract cross-app patterns into skill v1.9 and AGENTS.md#1
Merged
Conversation
Ports rules 26-29 back into the canonical YAML source (they had drifted into the generated SKILL.md only) and adds rules 30-36 capturing generic patterns observed across multiple downstream apps: public env bridge, router UX defaults, Link wrapper preserving search, public-route allowlist, Sentry user+feedback binding, single markdown artifact for help/AI/prompts, and distinct-value filter discovery tools. AGENTS.md gains inline amendments (hydration-safe color scheme, satisfies over as, pre-auth redirect middleware, loaderDeps cache keying, virtual-field explainer, fluent prompt builder, Zod round-trip factories, dual Playwright webServer) and new top-level sections for Public Runtime Config, Bulk Edit Pattern, Override/Overlay Repository Pattern, Sortable Tables, and Autosave Forms with concurrency guards. Made-with: Cursor
carlosvin
commented
Apr 19, 2026
carlosvin
commented
Apr 19, 2026
carlosvin
commented
Apr 19, 2026
carlosvin
commented
Apr 19, 2026
carlosvin
commented
Apr 19, 2026
carlosvin
commented
Apr 19, 2026
There was a problem hiding this comment.
Pull request overview
Updates the tanstack-fullstack-pattern skill to v1.9.0 by bringing the YAML source back in sync with generated artifacts, adding new cross-app architectural rules, and expanding AGENTS.md with operational patterns that support those rules.
Changes:
- Bump
tanstack-fullstack-patternto v1.9.0 and port rules 26–29 back into the YAML source of truth. - Add new rigid rules (30–36) and propagate them into the generated registry/dist/agent-skill outputs.
- Extend
AGENTS.mdwith new sections (Public Runtime Config, Bulk Edit, Overrides overlay, Sortable tables, Autosave concurrency guards) and inline amendments.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills/src/tanstack-fullstack-pattern.skill.yaml | Canonical skill source updated (v1.9.0, rules 26–36, refreshed capabilities/constraints/steps). |
| skills/registry.json | Generated registry updated to reflect new version and metadata. |
| skills/dist/tanstack-fullstack-pattern.md | Generated public markdown updated (v1.9.0 + new rules text). |
| AGENTS.md | Adds new operational guidance sections/amendments; renumbers “Validate Changes” section. |
| .agents/skills/tanstack-fullstack-pattern/SKILL.md | Generated agent-consumable skill updated with rules 26–36. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
tanstack-fullstack-patternskill to v1.9.0 by extracting generic, non-business-specific patterns observed across three downstream apps and adds the operational detail toAGENTS.md.SKILL.mdonly, so the build artifact was ahead of the canonical source. This restorespnpm skills:buildas the single path of truth.AGENTS.mdwith inline amendments (Tier 4) and 5 new top-level sections (Tier 3) covering the larger code patterns.New rigid rules in the skill (30–36)
getPublicEnv()+window.__ENV__inline<script>notFoundComponent)Linkwrapper that preserves search by defaultauthMiddlewarewith synthetic anonymousAuthContextSentry.setUser+feedbackIntegration({ autoInject: false })header buttondocs/help.mdbacks/help, an AI tool, and the chat's suggested promptsgetDistinctValues(field)method → server function → read-only AI tool for every enum-ish fieldNew AGENTS.md sections (13–17)
<script>injection,declare globalforwindow.__ENV__.bulkWritebatch mutations, "Apply all" row.applyOverrides(),\$set/\$unsetsemantics, "Revert to source".sortRows(), null-sinking.hasMountedguard for spurious mount PATCH,isPatchingref for concurrent PATCH collision prevention.Inline AGENTS.md amendments (Tier 4)
useComputedColorScheme+useIsMountedsatisfiesoveras,in-operator narrowing forunknownerrorsloaderDepscache keying, functional-formnavigate, child routes reading parent loader datawebServerwith in-process HTTP mockTest plan
pnpm skills:buildregeneratesSKILL.md,skills/dist/…, andskills/registry.jsonpnpm format— cleanpnpm lint— Biome +tsc --noEmit+skills:checkall greenSKILL.mdrendering in an agent session to confirm rules 30–36 surface when expectedMade with Cursor