fix nip-22 review feedback

Author: Priyanshubhartistm

src/handlers/event-message-handler.ts

@@ -165,7 +165,7 @@ export class EventMessageHandler implements IMessageHandler {
       limits.createdAt.maxPositiveDelta > 0 &&
       event.created_at > now + limits.createdAt.maxPositiveDelta
     ) {
-      return `invalid: created_at is more than ${limits.createdAt.maxPositiveDelta} seconds in the future`
+      return `rejected: created_at is more than ${limits.createdAt.maxPositiveDelta} seconds in the future`
     }
 
     if (

test/integration/features/nip-22/nip-22.feature

@@ -8,19 +8,11 @@ Feature: NIP-22 created_at timestamp limits
     When Alice subscribes to author Alice
     Then Alice receives a text_note event from Alice with content "test event"
 
-  Scenario: Event with created_at at positive delta limit is accepted
-    Given someone called Alice
-    And created_at limits are set to maxPositiveDelta 900 and maxNegativeDelta 0
-    When Alice drafts a text_note event with content "test event" and created_at 900 seconds from now
-    Then Alice sends their last draft event successfully
-    When Alice subscribes to author Alice
-    Then Alice receives a text_note event from Alice with content "test event"
-
   Scenario: Event with created_at above positive delta limit is rejected
     Given someone called Alice
     And created_at limits are set to maxPositiveDelta 900 and maxNegativeDelta 0
-    When Alice drafts a text_note event with content "test event" and created_at 901 seconds from now
-    Then Alice sends their last draft event unsuccessfully with reason containing "invalid"
+    When Alice drafts a text_note event with content "test event" and created_at 910 seconds from now
+    Then Alice sends their last draft event unsuccessfully with reason containing "rejected"
 
   Scenario: Event older than configured negative delta limit is rejected
     Given someone called Alice

test/integration/features/nip-22/nip-22.feature.ts

@@ -1,4 +1,4 @@
-import { After, Given, Then, When } from '@cucumber/cucumber'
+import { After, Before, Given, Then, When } from '@cucumber/cucumber'
 import { assocPath, pipe } from 'ramda'
 
 import { CommandResult, MessageType } from '../../../../src/@types/messages'
@@ -10,6 +10,8 @@ import { isDraft } from '../shared'
 import { SettingsStatic } from '../../../../src/utils/settings'
 import WebSocket from 'ws'
 
+const previousSettingsSnapshot = Symbol('nip22PreviousSettingsSnapshot')
+
 const setCreatedAtLimits = (maxPositiveDelta: number, maxNegativeDelta: number) => {
   const settings = SettingsStatic._settings ?? SettingsStatic.createSettings()
 
@@ -19,8 +21,13 @@ const setCreatedAtLimits = (maxPositiveDelta: number, maxNegativeDelta: number)
   )(settings) as any
 }
 
-After({ tags: '@nip-22' }, function() {
-  setCreatedAtLimits(900, 0)
+Before({ tags: '@nip-22' }, function(this: any) {
+  this[previousSettingsSnapshot] = SettingsStatic._settings
+})
+
+After({ tags: '@nip-22' }, function(this: any) {
+  SettingsStatic._settings = this[previousSettingsSnapshot]
+  delete this[previousSettingsSnapshot]
 })
 
 Given(/^created_at limits are set to maxPositiveDelta (\d+) and maxNegativeDelta (\d+)$/, function(