Skip to content

Commit 72f89e0

Browse files
authored
Merge pull request #57 from call-0f-code/member-Profile-update-fix
fix issue with profile update
2 parents 715c08d + a2c06a4 commit 72f89e0

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/controllers/member.controller.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export const updateAMember =
7474
(supabase: SupabaseClient) => async (req: Request, res: Response) => {
7575

7676
const { memberId } = req.params;
77-
77+
7878
if(!memberId) throw new ApiError("No memberId provided", 400);
7979

8080
const parsedBody = JSON.parse(req.body.memberData);
@@ -84,7 +84,7 @@ export const updateAMember =
8484
const oldData = await memberService.getDetails(memberId);
8585
const oldImage = oldData?.profilePhoto;
8686

87-
if(oldImage) await uploadImage(supabase, req.file, "members", oldImage);
87+
if(oldImage) imageUrl = await uploadImage(supabase, req.file, "members", oldImage);
8888
else imageUrl = await uploadImage(supabase, req.file, "members");
8989
}
9090
if (imageUrl) parsedBody.profilePhoto = imageUrl;
@@ -155,4 +155,4 @@ export const getUserInterviews = async (req: Request, res: Response) => {
155155

156156
const interviews = await memberService.getInterviews(memberId);
157157
res.status(200).json({ success: true, interviews });
158-
};
158+
};

tests/Member.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,10 @@ describe('Member Controller - updateAMember', () => {
180180
);
181181

182182
expect(memberService.updateMember).toHaveBeenCalledWith('abc-123', {
183+
profilePhoto: 'https://new.url/image.png',
183184
});
184185

186+
185187
expect(res.status).toHaveBeenCalledWith(200);
186188
expect(res.json).toHaveBeenCalledWith({
187189
success: true,

0 commit comments

Comments
 (0)