Merge pull request #59 from call-0f-code/member-Profile-update-fix

refactor image update logic in uploadImg function

Author: Sherin-2711

src/utils/imageUtils.ts

@@ -37,13 +37,7 @@ export async function uploadImage(
   }
   const ext = mime.split("/")[1];
 
-  let filename: string;
-  if (fileUrl) {
-    const { fileName } = extractFilePathAndNameFromUrl(fileUrl);
-    filename = fileName;
-  } else {
-    filename = `${uuidv4()}.${ext}`;
-  }
+  const filename:string =  `${uuidv4()}.${ext}`;
 
   const filePath = `${folder}/${filename}`;
 
@@ -66,6 +60,10 @@ export async function uploadImage(
     throw new ApiError("Failed to get public URL", 500);
   }
 
+  if (fileUrl) {
+    await deleteImage(supabase, fileUrl);
+  }
+
   return urlData.publicUrl;
 }
 

tests/imageUtils.test.ts

@@ -20,7 +20,7 @@ describe("imageUtils", () => {
     storageMock = {
       from: jest.fn().mockReturnThis(),
       upload: jest.fn(),
-      getPublicUrl: jest.fn(),
+      getPublicUrl: jest.fn(), 
       remove: jest.fn(),
     };
 
@@ -61,6 +61,7 @@ describe("imageUtils", () => {
       storageMock.getPublicUrl.mockReturnValue({
         data: { publicUrl: "https://public.url/existing.png" },
       });
+      storageMock.remove.mockReturnValue({error:null});
 
       const url = await uploadImage(
         mockSupabase as SupabaseClient,
@@ -70,7 +71,7 @@ describe("imageUtils", () => {
       );
       // Should use filename 'existing.png' instead of generating with uuid
       expect(storageMock.upload).toHaveBeenCalledWith(
-        "folder/existing.png",
+        "folder/test-uuid.png",
         dummyFile.buffer,
         { contentType: dummyFile.mimetype, upsert: true },
       );