Skip to content

Commit 0abf4b3

Browse files
committed
fix: exit with code 1 when GitHub download fails in add command
Also add CHANGELOG note about stricter build canister name validation. Made-with: Cursor
1 parent 60b733d commit 0abf4b3

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

cli/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
- Fix corrupted `mops.lock` file causing an unhandled crash instead of a helpful error message
1313
- Fix `mops sources` resolving package config from wrong directory in some contexts
1414
- Harden lock file integrity check against package ID prefix collisions
15+
- `mops build` now reports invalid canister names instead of silently ignoring them
1516
- Document `baseDir`, `readme`, and `dfx` fields in `[package]` config
1617

1718
## 2.4.0

cli/commands/add.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export async function add(
105105
verbose: verbose,
106106
});
107107
if (!res) {
108-
return;
108+
process.exit(1);
109109
}
110110
} else if (!pkgDetails.path) {
111111
let res = await installMopsDep(pkgDetails.name, pkgDetails.version, {

0 commit comments

Comments
 (0)