Skip to content

Move directions legend to lower-left and simplify map legend labels #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c0d3rb4b4 merged 1 commit into from
Feb 23, 2026
Merged

Move directions legend to lower-left and simplify map legend labels #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.1.20] — 2026-02-23

### Changed
- Moved the map direction legend controls to the lower-left legend stack so they no longer block the map action buttons.
- Simplified map legend labels by removing `On/Off` state text for direction, eclipse visibility, and central-path overlays.
- Bumped `apps/mobile` version to `1.1.20`.

## [1.1.19] — 2026-02-23

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@eclipse-timer/mobile",
"version": "1.1.19",
"version": "1.1.20",
"private": true,
"main": "index.js",
"scripts": {
Expand Down
170 changes: 74 additions & 96 deletions apps/mobile/src/screens/TimerScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,84 +532,81 @@ export default function TimerScreen({
<Text style={styles.mapOverlayBtnText}>{mapTypeText}</Text>
</Pressable>

<View style={styles.mapLegend}>
<Pressable
style={[
styles.mapLegendItem,
!timer.showVisibleOverlay ? styles.mapLegendMuted : null,
!timer.hasVisibleOverlayData ? styles.mapLegendDisabled : null,
]}
onPress={timer.toggleVisibleOverlay}
disabled={!timer.hasVisibleOverlayData}
accessibilityRole="button"
accessibilityLabel={
timer.showVisibleOverlay
? "Hide eclipse visible overlay"
: "Show eclipse visible overlay"
}
>
<View style={styles.mapLegendRow}>
<View style={[styles.mapLegendSwatch, { backgroundColor: visibleOverlayColor }]} />
<Text style={styles.mapLegendText}>Eclipse Visible</Text>
</View>
<Text style={styles.mapLegendState}>{timer.showVisibleOverlay ? "On" : "Off"}</Text>
</Pressable>
<View style={styles.mapLegendStack}>
{timer.result && timer.isResultCurrentForPin ? (
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render directions legend only when rows exist

This branch now renders the directions legend whenever timer.result is current, even when contactDirectionOverlays is empty (e.g., bearings are undefined for locations where no contact directions are available). Because the commit also removed the legend header/state text, that case produces an unlabeled empty dark box in the lower-left, which is a user-visible regression. Please gate this render on hasDirectionsData (or provide fallback content) so the legend is not shown empty.

Useful? React with 👍 / 👎.

<Pressable
style={[
styles.mapDirectionLegend,
!timer.showDirectionsOverlay ? styles.mapLegendMuted : null,
!hasDirectionsData ? styles.mapLegendDisabled : null,
]}
onPress={timer.toggleDirectionsOverlay}
disabled={!hasDirectionsData}
accessibilityRole="button"
accessibilityLabel={
timer.showDirectionsOverlay ? "Hide direction overlays" : "Show direction overlays"
}
>
{contactDirectionOverlays.map((direction) => (
<View
key={`direction-legend-${direction.key}`}
style={styles.mapDirectionLegendRow}
>
<View
style={[styles.mapDirectionLegendLine, { borderTopColor: direction.color }]}
/>
<Text style={[styles.mapDirectionLegendText, { color: direction.color }]}>
{direction.label}
</Text>
</View>
))}
</Pressable>
) : null}

<Pressable
style={[
styles.mapLegendItem,
!timer.showCentralOverlay ? styles.mapLegendMuted : null,
!timer.hasCentralOverlayData ? styles.mapLegendDisabled : null,
]}
onPress={timer.toggleCentralOverlay}
disabled={!timer.hasCentralOverlayData}
accessibilityRole="button"
accessibilityLabel={
timer.showCentralOverlay ? "Hide central path overlay" : "Show central path overlay"
}
>
<View style={styles.mapLegendRow}>
<View
style={[styles.mapLegendSwatch, { backgroundColor: activeCentralOverlayColor }]}
/>
<Text style={styles.mapLegendText}>{centralLegendLabel}</Text>
</View>
<Text style={styles.mapLegendState}>{timer.showCentralOverlay ? "On" : "Off"}</Text>
</Pressable>
</View>
<View style={styles.mapLegend}>
<Pressable
style={[
styles.mapLegendItem,
!timer.showVisibleOverlay ? styles.mapLegendMuted : null,
!timer.hasVisibleOverlayData ? styles.mapLegendDisabled : null,
]}
onPress={timer.toggleVisibleOverlay}
disabled={!timer.hasVisibleOverlayData}
accessibilityRole="button"
accessibilityLabel={
timer.showVisibleOverlay
? "Hide eclipse visible overlay"
: "Show eclipse visible overlay"
}
>
<View style={styles.mapLegendRow}>
<View style={[styles.mapLegendSwatch, { backgroundColor: visibleOverlayColor }]} />
<Text style={styles.mapLegendText}>Eclipse Visible</Text>
</View>
</Pressable>

{timer.result && timer.isResultCurrentForPin ? (
<Pressable
style={[
styles.mapDirectionLegend,
!timer.showDirectionsOverlay ? styles.mapLegendMuted : null,
!hasDirectionsData ? styles.mapLegendDisabled : null,
]}
onPress={timer.toggleDirectionsOverlay}
disabled={!hasDirectionsData}
accessibilityRole="button"
accessibilityLabel={
timer.showDirectionsOverlay ? "Hide direction overlays" : "Show direction overlays"
}
>
<View style={styles.mapDirectionLegendHeader}>
<Text style={styles.mapDirectionLegendTitle}>Directions</Text>
<Text style={styles.mapLegendState}>
{timer.showDirectionsOverlay ? "On" : "Off"}
</Text>
</View>
{contactDirectionOverlays.map((direction) => (
<View key={`direction-legend-${direction.key}`} style={styles.mapDirectionLegendRow}>
<Pressable
style={[
styles.mapLegendItem,
!timer.showCentralOverlay ? styles.mapLegendMuted : null,
!timer.hasCentralOverlayData ? styles.mapLegendDisabled : null,
]}
onPress={timer.toggleCentralOverlay}
disabled={!timer.hasCentralOverlayData}
accessibilityRole="button"
accessibilityLabel={
timer.showCentralOverlay ? "Hide central path overlay" : "Show central path overlay"
}
>
<View style={styles.mapLegendRow}>
<View
style={[styles.mapDirectionLegendLine, { borderTopColor: direction.color }]}
style={[styles.mapLegendSwatch, { backgroundColor: activeCentralOverlayColor }]}
/>
<Text style={[styles.mapDirectionLegendText, { color: direction.color }]}>
{direction.label}
</Text>
<Text style={styles.mapLegendText}>{centralLegendLabel}</Text>
</View>
))}
</Pressable>
) : null}
</Pressable>
</View>
</View>
</View>

<View style={styles.controls}>
Expand Down Expand Up @@ -1109,10 +1106,13 @@ const styles = StyleSheet.create({
borderRadius: 2,
backgroundColor: "white",
},
mapLegend: {
mapLegendStack: {
position: "absolute",
left: 10,
bottom: 10,
gap: 6,
},
mapLegend: {
paddingVertical: 7,
paddingHorizontal: 8,
borderRadius: 10,
Expand Down Expand Up @@ -1151,35 +1151,13 @@ const styles = StyleSheet.create({
fontSize: 11,
fontWeight: "600",
},
mapLegendState: {
color: "#d6d6d6",
fontSize: 10,
fontWeight: "700",
textTransform: "uppercase",
},
mapDirectionLegend: {
position: "absolute",
right: 10,
bottom: 10,
borderRadius: 10,
backgroundColor: "rgba(0,0,0,0.62)",
paddingHorizontal: 8,
paddingVertical: 7,
gap: 4,
},
mapDirectionLegendHeader: {
flexDirection: "row",
alignItems: "center",
justifyContent: "space-between",
gap: 8,
},
mapDirectionLegendTitle: {
color: "#e2e2e2",
fontSize: 10,
fontWeight: "700",
textTransform: "uppercase",
letterSpacing: 0.4,
},
mapDirectionLegendRow: {
flexDirection: "row",
alignItems: "center",
Expand Down