Move directions legend to lower-left and simplify map legend labels#9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3778d87e65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Text style={styles.mapLegendState}>{timer.showVisibleOverlay ? "On" : "Off"}</Text> | ||
| </Pressable> | ||
| <View style={styles.mapLegendStack}> | ||
| {timer.result && timer.isResultCurrentForPin ? ( |
There was a problem hiding this comment.
Render directions legend only when rows exist
This branch now renders the directions legend whenever timer.result is current, even when contactDirectionOverlays is empty (e.g., bearings are undefined for locations where no contact directions are available). Because the commit also removed the legend header/state text, that case produces an unlabeled empty dark box in the lower-left, which is a user-visible regression. Please gate this render on hasDirectionsData (or provide fallback content) so the legend is not shown empty.
Useful? React with 👍 / 👎.
Motivation
On/Offtext for overlay state.Description
mapLegendStackcontainer in the lower-left so it appears above the Eclipse Visible / central-path legends and no longer blocks lower-right map buttons; changes located inapps/mobile/src/screens/TimerScreen.tsx.On/Offstate text from the Directions, Eclipse Visible, and central-path legend items and rely on existingmapLegendMuted/mapLegendDisabledstyling to convey state.mapLegendStack, adjustedmapLegendandmapDirectionLegendusage and removed the separate title/state header for Directions in the layout; updates are inapps/mobile/src/screens/TimerScreen.tsxstyle definitions.apps/mobileversion from1.1.19to1.1.20inapps/mobile/package.jsonand added an entry toCHANGELOG.mddescribing the change.Testing
pnpm -C apps/mobile typecheckand it completed successfully.pnpm -C apps/mobile lintand no lint issues were reported.pnpm -C apps/mobile web -- --port 8081which failed due to Expo web not being enabled in the project app config (expected environmental limitation).Codex Task