Skip to content

Move directions legend to lower-left and simplify map legend labels#9

Merged
c0d3rb4b4 merged 1 commit into
mainfrom
codex/update-legend-controls-on-the-map
Feb 23, 2026
Merged

Move directions legend to lower-left and simplify map legend labels#9
c0d3rb4b4 merged 1 commit into
mainfrom
codex/update-legend-controls-on-the-map

Conversation

@c0d3rb4b4
Copy link
Copy Markdown
Owner

Motivation

  • Prevent the Directions legend from overlapping map action controls (e.g. "View in Maps") while keeping all overlay toggles visually grouped.
  • Reduce visual clutter by relying on muted styling rather than explicit On/Off text for overlay state.
  • Bump the mobile package version and document the UI change in the changelog for release tracking.

Description

  • Moved the Directions legend into a new mapLegendStack container in the lower-left so it appears above the Eclipse Visible / central-path legends and no longer blocks lower-right map buttons; changes located in apps/mobile/src/screens/TimerScreen.tsx.
  • Removed the explicit On/Off state text from the Directions, Eclipse Visible, and central-path legend items and rely on existing mapLegendMuted / mapLegendDisabled styling to convey state.
  • Reworked styles: added mapLegendStack, adjusted mapLegend and mapDirectionLegend usage and removed the separate title/state header for Directions in the layout; updates are in apps/mobile/src/screens/TimerScreen.tsx style definitions.
  • Bumped apps/mobile version from 1.1.19 to 1.1.20 in apps/mobile/package.json and added an entry to CHANGELOG.md describing the change.

Testing

  • Ran pnpm -C apps/mobile typecheck and it completed successfully.
  • Ran pnpm -C apps/mobile lint and no lint issues were reported.
  • Attempted pnpm -C apps/mobile web -- --port 8081 which failed due to Expo web not being enabled in the project app config (expected environmental limitation).

Codex Task

@c0d3rb4b4 c0d3rb4b4 merged commit 6194ba5 into main Feb 23, 2026
1 check passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3778d87e65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<Text style={styles.mapLegendState}>{timer.showVisibleOverlay ? "On" : "Off"}</Text>
</Pressable>
<View style={styles.mapLegendStack}>
{timer.result && timer.isResultCurrentForPin ? (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render directions legend only when rows exist

This branch now renders the directions legend whenever timer.result is current, even when contactDirectionOverlays is empty (e.g., bearings are undefined for locations where no contact directions are available). Because the commit also removed the legend header/state text, that case produces an unlabeled empty dark box in the lower-left, which is a user-visible regression. Please gate this render on hasDirectionsData (or provide fallback content) so the legend is not shown empty.

Useful? React with 👍 / 👎.

@c0d3rb4b4 c0d3rb4b4 deleted the codex/update-legend-controls-on-the-map branch February 26, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant